Improve visibility of hyphen/dash in the PowerShell ISE theme when typing in the editor #862
Conversation
The lineHighlighBackground settings has the same color as dashes being used when typing interactively. Changed setting from Changed editor.lineHighlightBackground setting from #94c6f7 to #add8e6 More info: PowerShell/PowerShellEditorServices#511
|
@stefanstranger, It will cover your contributions to all Microsoft-managed open source projects. |
|
You shouldn't have to sign a CLA for a one-line change, I think the automation bot is getting confused by all the other commits. Can you check the "Allow edits from maintainers" box here:
Once that's checked I can fix it for you. |
|
I wonder if this should be rebased against |
|
Yeah, that's the fix, I just didn't want him to have to learn how to rebase for his first PR ;) |
|
Strange, I tried rebasing his branch and it appears to be up to date. Not sure what's going on there... |
|
The PR is trying to merge into |
|
Nice catch! That was the issue. |
|
I'm going to close/reopen to see if it gets CLA bot to not require CLA. |
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
|
It's only taken about a year and a half but I'm finally starting to grok Git with much help/coaching from you - so thanks! |
|
Haha, you give me too much credit. Thanks for the PR Stefan, merging it! |
daviwil
changed the title
|
Was this just an update to the editor highlight color? I'm not certain what dashes were not visible - @stefanstranger do you have a screenshot? |
Solves issue with not seeing dashes when editor line is selected.
Fixes #864.