Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a standard PowerShell name for psedit and make psedit an alias #528

Closed
rkeithhill opened this issue Jun 22, 2017 · 12 comments
Closed
Assignees
Labels
Area-Extension Terminal Issue-Enhancement A feature request (enhancement).
Milestone

Comments

@rkeithhill
Copy link
Contributor

Perhaps we call the command Open-FileInVSCode or if it is editor independent - Open-FileInEditor?

@daviwil
Copy link
Contributor

daviwil commented Jun 28, 2017

We can definitely do that. Once I start adding workspace cmdlets I'll alias Open-TextDocument (or whatever I call the noun) as psedit.

@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label Jun 28, 2017
@daviwil daviwil added this to the July 2017 milestone Jun 28, 2017
@daviwil daviwil modified the milestones: July 2017, Backlog Oct 27, 2017
@TylerLeonhardt TylerLeonhardt modified the milestones: Backlog, 1.6.0 Jan 10, 2018
@TylerLeonhardt TylerLeonhardt self-assigned this Jan 10, 2018
@TylerLeonhardt
Copy link
Member

This looks like a low hanging fruit.

@daviwil
Copy link
Contributor

daviwil commented Jan 10, 2018

It'll be easy but we should probably discuss naming and whatnot first

@TylerLeonhardt
Copy link
Member

I like Open-FileInEditor since it's not specific to VSCode but it's specific to say that the file will open in the editor.

Thoughts?

@daviwil
Copy link
Contributor

daviwil commented Jan 10, 2018

I think we need a more noun-centric approach, like WorkspaceFile or TextDocument so that there can be Open, New, Save, Close, etc verbs. I think at the time I filed this I was trying to make up my mind whether I wanted to use the Language Server Protocol nomenclature of TextDocument or something else. I suppose it could be EditorFile.

@rkeithhill and @SeeminglyScience, any other possibilities here?

@SeeminglyScience
Copy link
Collaborator

I think it's important that Editor be somewhere in the noun. My vote goes to EditorFile or maybe EditorDocument but discoverability might not be great on the latter. I really like TextDocument as well but I feel like it only makes sense if you're familiar with the language server which won't be the case for most.

@rkeithhill
Copy link
Contributor Author

I like Open-EditorFile. We already have Import/Register/Unregister-EditorCommand. So EditorFile as a noun, fits in nicely.

@daviwil
Copy link
Contributor

daviwil commented Jan 11, 2018

Cool! Let's use EditorFile then. I think anything else could be confusing or hard to find. Maybe it's best to add the rest of the cmdlets when the Open variant is added?

@SeeminglyScience
Copy link
Collaborator

While we're talking about it, also Get-EditorContext and Get-EditorCommand

@daviwil
Copy link
Contributor

daviwil commented Jan 11, 2018

Definitely Get-EditorContext too. What might someone use Get-EditorCommand for?

@SeeminglyScience
Copy link
Collaborator

Same thing you use any Get- command for ;)

Mostly just information, but also for piping to other commands like Unregister-EditorCommand

@daviwil
Copy link
Contributor

daviwil commented Jan 11, 2018

Ahhh, cool, makes sense :) Definitely, Get | Unregister makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extension Terminal Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

4 participants