From 3ae17e83ff93f0421c151f3bb72c2e28d9ed5069 Mon Sep 17 00:00:00 2001 From: Andrew Schwartzmeyer Date: Tue, 16 Mar 2021 15:52:15 -0700 Subject: [PATCH] Fix `TelemetryEventParams` --- src/PowerShellEditorServices/Logging/PsesTelemetryEvent.cs | 4 ++-- .../Services/Workspace/Handlers/ConfigurationHandler.cs | 2 +- test/PowerShellEditorServices.Test.E2E/LSPTestsFixures.cs | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PowerShellEditorServices/Logging/PsesTelemetryEvent.cs b/src/PowerShellEditorServices/Logging/PsesTelemetryEvent.cs index 4d55320be..0ee68b9e2 100644 --- a/src/PowerShellEditorServices/Logging/PsesTelemetryEvent.cs +++ b/src/PowerShellEditorServices/Logging/PsesTelemetryEvent.cs @@ -9,10 +9,10 @@ namespace Microsoft.PowerShell.EditorServices.Logging { // This inheirits from Dictionary so that it can be passed in to SendTelemetryEvent() - // which takes in an IDictionary + // which takes in an IDictionary // However, I wanted creation to be easy so you can do // new PsesTelemetryEvent { EventName = "eventName", Data = data } - internal class PsesTelemetryEvent : Dictionary + internal class PsesTelemetryEvent : Dictionary { public string EventName { diff --git a/src/PowerShellEditorServices/Services/Workspace/Handlers/ConfigurationHandler.cs b/src/PowerShellEditorServices/Services/Workspace/Handlers/ConfigurationHandler.cs index 6502fde43..5d47f31fb 100644 --- a/src/PowerShellEditorServices/Services/Workspace/Handlers/ConfigurationHandler.cs +++ b/src/PowerShellEditorServices/Services/Workspace/Handlers/ConfigurationHandler.cs @@ -193,7 +193,7 @@ private void SendFeatureChangesTelemetry(LanguageServerSettingsWrapper incomingS _languageServer.Window.SendTelemetryEvent(new TelemetryEventParams { - Data = new PsesTelemetryEvent + ExtensionData = new PsesTelemetryEvent { EventName = "NonDefaultPsesFeatureConfiguration", Data = JObject.FromObject(configChanges) diff --git a/test/PowerShellEditorServices.Test.E2E/LSPTestsFixures.cs b/test/PowerShellEditorServices.Test.E2E/LSPTestsFixures.cs index ebf2c4692..fb283f775 100644 --- a/test/PowerShellEditorServices.Test.E2E/LSPTestsFixures.cs +++ b/test/PowerShellEditorServices.Test.E2E/LSPTestsFixures.cs @@ -63,8 +63,8 @@ public async Task InitializeAsync() .OnTelemetryEvent(telemetryEventParams => TelemetryEvents.Add( new PsesTelemetryEvent { - EventName = (string) telemetryEventParams.Data["eventName"], - Data = telemetryEventParams.Data["data"] as JObject + EventName = (string)telemetryEventParams.ExtensionData["eventName"], + Data = telemetryEventParams.ExtensionData["data"] as JObject })); // Enable all capabilities this this is for testing.