Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative funnel time conversion bin times #5116

Closed
1 of 2 tasks
alexkim205 opened this issue Jul 14, 2021 · 3 comments · Fixed by #5283
Closed
1 of 2 tasks

Negative funnel time conversion bin times #5116

alexkim205 opened this issue Jul 14, 2021 · 3 comments · Fixed by #5283
Assignees
Labels
bug Something isn't working right feature/funnels Feature Tag: Funnels

Comments

@alexkim205
Copy link
Contributor

Bug description

The new funnels time conversion endpoint sometimes returns bins with negative time values. This makes it difficult to reflect accurate time conversion funnels data on the frontend. @Twixes @neilkakkar

Screen Shot 2021-07-13 at 9 14 42 PM

Example CH localhost link to reproduce bug.

Request Payload

Screen Shot 2021-07-13 at 9 19 06 PM

Expected behavior

No negative time bin values.

How to reproduce

  1. Navigate to new funnels time conversion page. Make sure to turn on this FF: 4535-funnel-bar-viz
  2. Add a few identical actions/events
  3. Open up network requests to see the response to api/funnels

Environment

  • PostHog Cloud
  • self-hosted PostHog, version/commit: please provide

Thank you for your bug report – we love squashing them!

@alexkim205 alexkim205 added bug Something isn't working right feature/funnels Feature Tag: Funnels core-analytics labels Jul 14, 2021
@alexkim205 alexkim205 changed the title Funnel Time Conversion Bins Funnel time conversion bins are negative Jul 15, 2021
@alexkim205 alexkim205 changed the title Funnel time conversion bins are negative Negative funnel time conversion bin times Jul 15, 2021
@liyiy
Copy link
Contributor

liyiy commented Jul 15, 2021

This is a graph that had those negative time values

Screen Shot 2021-07-15 at 3 35 34 PM

@neilkakkar neilkakkar self-assigned this Jul 16, 2021
@neilkakkar
Copy link
Contributor

Very interesting: Not an issue with time to convert, but the underlying time averages. And it turns out, this happens sporadically: sometimes, the time conversion values are borked, (and in your unfortunate case, cached), so the graph appears like this^.

I tried clearing the cache, and making the request again, and it worked fine.

Sigh, now to figure out why event duplicates are flakey O.o

@neilkakkar
Copy link
Contributor

Partially because of: ClickHouse/ClickHouse#26580 . And from what my experiments tell me, only happens when dealing with duplicate events. If the steps are not both $pageview, never happens. If the steps are both $pageview, happens sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right feature/funnels Feature Tag: Funnels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants