From a0d81d7e9f6a1eb202da171b47f92dbdafd9fc33 Mon Sep 17 00:00:00 2001 From: Haven Barnes Date: Mon, 13 Jan 2025 15:09:31 -0800 Subject: [PATCH 1/2] feat: add irclid and _kx as campaign parameters --- src/utils/event-utils.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/utils/event-utils.ts b/src/utils/event-utils.ts index fdb69a23c..f9da2a239 100644 --- a/src/utils/event-utils.ts +++ b/src/utils/event-utils.ts @@ -30,6 +30,8 @@ export const CAMPAIGN_PARAMS = [ 'igshid', // instagram 'ttclid', // tiktok 'rdt_cid', // reddit + 'irclid', // impact + '_kx', // klaviyo ] export const EVENT_TO_PERSON_PROPERTIES = [ From a4a99d96e578b1a26b8693f5bf62005985cea4b9 Mon Sep 17 00:00:00 2001 From: Haven Barnes Date: Mon, 13 Jan 2025 15:17:36 -0800 Subject: [PATCH 2/2] update tests --- ...AllPersonProfilePropertiesAsPersonPropertiesForFlags.test.ts | 2 ++ src/__tests__/personProcessing.test.ts | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/__tests__/customizations/setAllPersonProfilePropertiesAsPersonPropertiesForFlags.test.ts b/src/__tests__/customizations/setAllPersonProfilePropertiesAsPersonPropertiesForFlags.test.ts index f1ec7fbae..6169d9387 100644 --- a/src/__tests__/customizations/setAllPersonProfilePropertiesAsPersonPropertiesForFlags.test.ts +++ b/src/__tests__/customizations/setAllPersonProfilePropertiesAsPersonPropertiesForFlags.test.ts @@ -63,6 +63,7 @@ describe('setAllPersonPropertiesForFlags', () => { "$os_version": "4.4.0", "$referrer": "https://referrer.com", "$referring_domain": "referrer.com", + "_kx": null, "dclid": null, "fbclid": null, "gad_source": null, @@ -70,6 +71,7 @@ describe('setAllPersonPropertiesForFlags', () => { "gclid": null, "gclsrc": null, "igshid": null, + "irclid": null, "li_fat_id": null, "mc_cid": null, "msclkid": null, diff --git a/src/__tests__/personProcessing.test.ts b/src/__tests__/personProcessing.test.ts index a384029b9..ce0e92361 100644 --- a/src/__tests__/personProcessing.test.ts +++ b/src/__tests__/personProcessing.test.ts @@ -7,6 +7,7 @@ import { RemoteConfig } from '../types' const INITIAL_CAMPAIGN_PARAMS_NULL = { $initial_current_url: null, + $initial__kx: null, $initial_dclid: null, $initial_fbclid: null, $initial_gad_source: null, @@ -15,6 +16,7 @@ const INITIAL_CAMPAIGN_PARAMS_NULL = { $initial_gclsrc: null, $initial_host: null, $initial_igshid: null, + $initial_irclid: null, $initial_li_fat_id: null, $initial_mc_cid: null, $initial_msclkid: null,