Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create memory queue #6863

Closed
mariusandra opened this issue May 23, 2021 · 2 comments
Closed

Create memory queue #6863

mariusandra opened this issue May 23, 2021 · 2 comments
Labels

Comments

@mariusandra
Copy link
Collaborator

For job queues we currently have (almost) two implemented: 1) graphile, 2) S3

We could add a third one: memory. This should only work with runNow() jobs and only if there are not too many of them.

The tricky part is that jobs are enqueued in worker threads, but are then distributed to workers in the main thread. Thus we need some form of communication channel between threads. Jobs can be huge (100MB for S3?), so support for buffering/chunking the payload when sending between threads might be needed.

The GeoIP plugin implements a local TCP server for communication between threads. Perhaps this could be used as well here, or some other channel can be created.

We're running a patched fork of Piscina and they didn't want to accept our changes upstream, so we can go wild with how we implement this :).

Also, this memory queue should

  1. have some way of knowing "sorry, I'm full" and then rejecting jobs
  2. have some way of flushing all events to the next persistent queue (postgres probably) when the server terminates
@tiina303 tiina303 transferred this issue from PostHog/plugin-server Nov 3, 2021
@posthog-bot
Copy link
Contributor

This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

@posthog-bot
Copy link
Contributor

This issue was closed due to lack of activity. Feel free to reopen if it's still relevant.

@posthog-bot posthog-bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
@github-project-automation github-project-automation bot moved this to Done This Sprint in Extensibility Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done This Sprint
Development

No branches or pull requests

2 participants