Skip to content
This repository has been archived by the owner on Nov 4, 2021. It is now read-only.

Handle errors thrown inside plugins #131

Closed
Twixes opened this issue Feb 4, 2021 · 2 comments
Closed

Handle errors thrown inside plugins #131

Twixes opened this issue Feb 4, 2021 · 2 comments

Comments

@Twixes
Copy link
Member

Twixes commented Feb 4, 2021

Currently if a plugin method throws an error, it will bubble up the server and get caught by Sentry (like this). We should logs these errors in a smarter way, so that they can be useful to plugin users and don't pollute our Sentry data.

@Twixes
Copy link
Member Author

Twixes commented Feb 5, 2021

We probably should resolve #72 before and use that solution here too.

@mariusandra
Copy link
Collaborator

These errors do get captured via processError and stored on the plugin config table. #146 silenced them, so closing.

#72 is a separate topic and will definitely enhance error collection!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants