-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📒 Add Ledger support #398
Merged
Merged
📒 Add Ledger support #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on |
009e25f
to
291568a
Compare
a6828af
to
5e2c3a4
Compare
291568a
to
ded6423
Compare
5e2c3a4
to
fdf5426
Compare
ded6423
to
ff9f101
Compare
fdf5426
to
74624f3
Compare
88e56a7
to
bade02e
Compare
ff9f101
to
6734b0c
Compare
bade02e
to
d9ac4a4
Compare
6734b0c
to
cfbf0ef
Compare
d9ac4a4
to
b86d878
Compare
cfbf0ef
to
5c97cb0
Compare
b86d878
to
4674903
Compare
2e7825f
to
958304f
Compare
lrazovic
approved these changes
Sep 12, 2024
4674903
to
20bda10
Compare
2a14aa9
to
670eeae
Compare
Merge activity
|
Merged
This was referenced Sep 12, 2024
670eeae
to
4eb68fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
How?
Testing?
@lrazovic can you try it out with zombienet since you have a ledger nano?
Anything Else?
There are 2 places where I had to initialise the signed extensions with ::new(), but not sure if the argument inside should be
true
orfalse
. I set it to true