Skip to content

Add function to aggregate outputs for display in society-wide outputs page #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks done
anth-volk opened this issue Apr 3, 2025 · 1 comment · May be fixed by #2499
Open
5 tasks done

Add function to aggregate outputs for display in society-wide outputs page #2471

anth-volk opened this issue Apr 3, 2025 · 1 comment · May be fixed by #2499
Assignees

Comments

@anth-volk
Copy link
Collaborator

anth-volk commented Apr 3, 2025

This function should do the following:

Given an instance of the society-wide structure we currently use, aggregate the values from the structures to create one aggregated instance of the same schema; this may be challenging, as for some values, we'll need the aggregate; for some, we'll need mean; and for others, perhaps something else?

I will want to confirm with Pavel or Nikhil how they calculate multi-year impacts just to be 100.0% certain this function is doing the math properly.

  • Create function to aggregate a series of SocietyWideImpact items into one aggregated total output
  • Write tests for the above function
  • Modify function to remove unneeded outputs - only want to aggregate top-line items - we only want the data needed for the overview page
  • Create schema representing aggregated impacts
  • Re-open PR off of a clone instead of a fork
@PavelMakarchuk
Copy link
Collaborator

For the common web app outputs:
Budgetary impact: sum
Distributional impacts / Winners and Losers / Poverty / Inequality : mean

Unsure whether we want to and how we would handle the cliff impacts and LSRs (will take over an hour in the current state)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
2 participants