-
-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pokemon cries to the api #982
Comments
Give me some days to think about it. Questions: do we have all the cries? Could we serve the original file type or is it better to convert them for quality/portability reasons? |
ogg and mp3 is readily available (veekun and showdown) for wavs they are also available on showdown but size is quite a bit bigger i am not professional with audio stuff perhaps someone experienced could differentiate between quality to check whether trade off between size and quality is viable ogg and mp3s wavs directly ripped wavs from games bulbasaur cries
Here is the zip with those sounds downloaded |
Are there multiple sounds for each game version? Should we do a similar thing as we did for the sprites? |
We should also make sure those sounds are playable if we serve them. Ideally we will host them in a separate repo and the like will be something like https://raw.githubusercontent.com/PokeAPI/cries/master/cries/pokemon/132.ogg. Maybe you can create a test repo with only one sprite and reference it in an HTML page to see if it plays. |
Its not game wise completely old games upto gen 5 had a different sound available and from pokemon xy the old sounds have been replaced with new ones for most Pokemon. So there are 2 sounds available for Pokemon upto gen 5 Also html supports
|
Ok, let's use ogg! I'll make a new repo and we can start using that one. We can use the same tree we are using for the sprites. So something like:
We can add only one generation only initially and build the code API-wise. |
I am working on this pr rn ran into an issue mainly is that pokemon cries upto gen 5 is same for all games going forward from gen 6 the cries were revised so essentially there are only two sets of cries |
Or... we could just add the revised :) Can you point me to the 2 sets? OR info about that? |
https://veekun.com/dex/media/pokemon/cries/ |
I listened to them (bulbasaur) and they all differ. Let's use the most recent and complete set and add those only for now |
sure, I'll go with the showdown ones then |
Complete with pr #1030 |
In relation to this super ancient issue #242 I think it would be a great idea to have pokemon cries in the api
I am willing to work on a pr for this just want to clear some doubts beforehand getting started, what would be preferred format for the sounds files (ogg, mp3, wav)?
@Naramsim any thoughts about this?
The text was updated successfully, but these errors were encountered: