Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pokemon cries to the api #982

Closed
FallenDeity opened this issue Dec 24, 2023 · 12 comments
Closed

Adding pokemon cries to the api #982

FallenDeity opened this issue Dec 24, 2023 · 12 comments

Comments

@FallenDeity
Copy link
Contributor

FallenDeity commented Dec 24, 2023

In relation to this super ancient issue #242 I think it would be a great idea to have pokemon cries in the api

I am willing to work on a pr for this just want to clear some doubts beforehand getting started, what would be preferred format for the sounds files (ogg, mp3, wav)?

@Naramsim any thoughts about this?

@Naramsim
Copy link
Member

Give me some days to think about it.

Questions: do we have all the cries? Could we serve the original file type or is it better to convert them for quality/portability reasons?

@FallenDeity
Copy link
Contributor Author

FallenDeity commented Dec 30, 2023

ogg and mp3 is readily available (veekun and showdown) for wavs they are also available on showdown but size is quite a bit bigger i am not professional with audio stuff perhaps someone experienced could differentiate between quality to check whether trade off between size and quality is viable

ogg and mp3s
https://play.pokemonshowdown.com/audio/cries/

wavs
https://play.pokemonshowdown.com/audio/cries/src

directly ripped wavs from games
https://drive.google.com/drive/folders/1-1gquXnADe9fdQ7GDM0wFGIV36_O_g3L?usp=sharing

bulbasaur cries

ripped wav showdown wav veekun ogg showdown ogg showdown mp3
link link link link link

Here is the zip with those sounds downloaded

001.zip

@Naramsim
Copy link
Member

Are there multiple sounds for each game version? Should we do a similar thing as we did for the sprites?

@Naramsim
Copy link
Member

We should also make sure those sounds are playable if we serve them. Ideally we will host them in a separate repo and the like will be something like https://raw.githubusercontent.com/PokeAPI/cries/master/cries/pokemon/132.ogg. Maybe you can create a test repo with only one sprite and reference it in an HTML page to see if it plays.

@FallenDeity
Copy link
Contributor Author

Are there multiple sounds for each game version? Should we do a similar thing as we did for the sprites?

Its not game wise completely old games upto gen 5 had a different sound available and from pokemon xy the old sounds have been replaced with new ones for most Pokemon. So there are 2 sounds available for Pokemon upto gen 5

Also html supports

  • mp3
  • wav
  • ogg
    For in browser playing

@Naramsim
Copy link
Member

Ok, let's use ogg! I'll make a new repo and we can start using that one. We can use the same tree we are using for the sprites. So something like:

/cries/pokemon/versions/generation-i/1.ogg
/cries/pokemon/other/...

We can add only one generation only initially and build the code API-wise.

@FallenDeity
Copy link
Contributor Author

Ok, let's use ogg! I'll make a new repo and we can start using that one. We can use the same tree we are using for the sprites. So something like:

/cries/pokemon/versions/generation-i/1.ogg
/cries/pokemon/other/...

We can add only one generation only initially and build the code API-wise.

I am working on this pr rn ran into an issue mainly is that pokemon cries upto gen 5 is same for all games going forward from gen 6 the cries were revised so essentially there are only two sets of cries old set (gen 1 - gen 5) and revised set (gen 1 - gen 9) so if we are making it generation wise wont a lot of tracks be repeated?

@Naramsim
Copy link
Member

Or... we could just add the revised :)

Can you point me to the 2 sets? OR info about that?

@FallenDeity
Copy link
Contributor Author

https://veekun.com/dex/media/pokemon/cries/
Veekun for old ones
https://play.pokemonshowdown.com/audio/cries/
showdown for newer ones
https://drive.google.com/drive/folders/1-1gquXnADe9fdQ7GDM0wFGIV36_O_g3L?usp=sharing (these are a few other i took and converted to compare quality)

@Naramsim
Copy link
Member

I listened to them (bulbasaur) and they all differ. Let's use the most recent and complete set and add those only for now

@FallenDeity
Copy link
Contributor Author

FallenDeity commented Jan 18, 2024

sure, I'll go with the showdown ones then

@FallenDeity
Copy link
Contributor Author

Complete with pr #1030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants