-
-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pokedex/12 is missing 3 entries #597
Comments
I see, Bulbapedia and pokemondb have those. Serebii doens't. Who do we trust? 😄 Is there an official document from pokemon.com? |
Update to this, Bulbapedia and pokewiki probably took the entries from the official strategy guide book. |
So, their info is official. You can fill in a PR and we'll review it :) |
The problem is, I dont even know how to work with .csv files etc. So yea ... |
@LuziferSenpai I ping you here. I deployed a custom pokeapi trying to get rid of the You can use this URL: https://staging.pokeapi.co/api/v2/ |
@Naramsim Thanks! After redoing the code a bit and using resource, I was able to catch errors and then when that happens, use the staging side! |
Nono, @LuziferSenpai could you be our tester and only use staging.pokeapi.co for a day or two and do some extensive testing? Trying to trigger the very same |
@Naramsim It works like a charm! No real errros, other then timeouts! |
Hmm, okok, can you test also tomorrow? What do you mean by timeout? |
Just a time expired thing I think. Yea, will test it tomorrow too. |
ok, so you have many timeouts. I need to investigate that. But thanks a lot @LuziferSenpai for your testing! |
@Naramsim Always there to help. |
@LuziferSenpai the timeouts you were experiencing made me think that it's our function that has a timeout of 10s. So maybe, in production, it times out, a 404 is returned and cached by Cloudflare. I increased the timeout from 10s to 30s, in production. I also purged all the cache. For the next day, could you go back to using https://pokeapi.co? And inform me if you encounter any new Also, when you were using staging.pokeapi.co, could you tell me which HTTP requests caused the timeouts? |
@Naramsim will be done tomorrow ^^ |
@Naramsim Sry it took so long. Here is the test with the normal api. |
Hi @LuziferSenpai, can you try using again https://staging.pokeapi.co/api/v2/? I made some modifications and I believe the issue could be fixed now. Can you please report all the errors you'll encounter? Thanks a lot! |
@Naramsim Still getting a single timeout error, thats all. |
Closing |
Hey,
pokedex/12 -> pokemon_entries has only 150, but the dex goes up to 153.
Missing is:
The text was updated successfully, but these errors were encountered: