Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pokedex/12 is missing 3 entries #597

Closed
LuziferSenpai opened this issue Mar 16, 2021 · 20 comments
Closed

pokedex/12 is missing 3 entries #597

LuziferSenpai opened this issue Mar 16, 2021 · 20 comments

Comments

@LuziferSenpai
Copy link

Hey,

pokedex/12 -> pokemon_entries has only 150, but the dex goes up to 153.

Missing is:

  1. Diancie
  2. Hoopa
  3. Volcanion
@Naramsim
Copy link
Member

I see,

Bulbapedia and pokemondb have those. Serebii doens't. Who do we trust? 😄 Is there an official document from pokemon.com?

@LuziferSenpai
Copy link
Author

@LuziferSenpai
Copy link
Author

Update to this, Bulbapedia and pokewiki probably took the entries from the official strategy guide book.

@Naramsim
Copy link
Member

So, their info is official.

You can fill in a PR and we'll review it :)

@LuziferSenpai
Copy link
Author

The problem is, I dont even know how to work with .csv files etc. So yea ...

@Naramsim
Copy link
Member

@LuziferSenpai I ping you here.

I deployed a custom pokeapi trying to get rid of the / problem. Could you try it in your project and see if the problem happens again?

You can use this URL: https://staging.pokeapi.co/api/v2/

@LuziferSenpai
Copy link
Author

@Naramsim Thanks! After redoing the code a bit and using resource, I was able to catch errors and then when that happens, use the staging side!

@Naramsim
Copy link
Member

Naramsim commented Mar 25, 2021

Nono, @LuziferSenpai could you be our tester and only use staging.pokeapi.co for a day or two and do some extensive testing? Trying to trigger the very same / errors you encountered in the past?

@LuziferSenpai
Copy link
Author

@Naramsim It works like a charm! No real errros, other then timeouts!

@Naramsim
Copy link
Member

Hmm, okok, can you test also tomorrow?

What do you mean by timeout?

@LuziferSenpai
Copy link
Author

Just a time expired thing I think. Yea, will test it tomorrow too.

@LuziferSenpai
Copy link
Author

chrome_h3f77mf65x

That is what I get, but otherwise it works today too like a charm.

@Naramsim
Copy link
Member

ok, so you have many timeouts. I need to investigate that. But thanks a lot @LuziferSenpai for your testing!

@LuziferSenpai
Copy link
Author

@Naramsim Always there to help.

@Naramsim
Copy link
Member

Naramsim commented Mar 26, 2021

@LuziferSenpai the timeouts you were experiencing made me think that it's our function that has a timeout of 10s. So maybe, in production, it times out, a 404 is returned and cached by Cloudflare.

I increased the timeout from 10s to 30s, in production. I also purged all the cache. For the next day, could you go back to using https://pokeapi.co? And inform me if you encounter any new \ errors?

Also, when you were using staging.pokeapi.co, could you tell me which HTTP requests caused the timeouts?

@LuziferSenpai
Copy link
Author

@Naramsim will be done tomorrow ^^

@LuziferSenpai
Copy link
Author

@Naramsim Sry it took so long.

Here is the test with the normal api.

chrome_SQLIg8OOGO

@Naramsim
Copy link
Member

Hi @LuziferSenpai, can you try using again https://staging.pokeapi.co/api/v2/?

I made some modifications and I believe the issue could be fixed now. Can you please report all the errors you'll encounter? Thanks a lot!

@LuziferSenpai
Copy link
Author

@Naramsim Still getting a single timeout error, thats all.

@Naramsim
Copy link
Member

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants