Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/v2/csv/pokemon_moves.csv is no longer a well-formatted csv #1212

Open
SiAce opened this issue Feb 28, 2025 · 2 comments
Open

data/v2/csv/pokemon_moves.csv is no longer a well-formatted csv #1212

SiAce opened this issue Feb 28, 2025 · 2 comments

Comments

@SiAce
Copy link

SiAce commented Feb 28, 2025

Issue:

data/v2/csv/pokemon_moves.csv is no longer a well-formatted csv after the commit 8453c31.
This commit introduced a new column mastery but didn't add the extra comma for the rows where mastery is empty. This change made this csv file no longer a well-formatted csv and could cause many csv parser to fail.

Steps to Reproduce:

  1. Download data/v2/csv/pokemon_moves.csv
  2. Check the content of the file and find out that there are 7 columns in the header but many rows are missing a trailing comma and there are only 5 commas (for example the first row)

Expected Behavior

Either

  1. Add the missing comma for all rows where mastery is empty
  2. Remove mastery column
@Naramsim
Copy link
Member

Naramsim commented Mar 1, 2025

Hi thanks for pointing it out!

Could you open a PR proposing a fix? Many thanks!

@Naramsim
Copy link
Member

Naramsim commented Mar 1, 2025

Edit, I fixed it here #1214 but found another problem in a different csv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants