Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation IX Pokémon do not Have Shape Data #1120

Closed
KyroChi opened this issue Aug 15, 2024 · 3 comments · Fixed by #1122
Closed

Generation IX Pokémon do not Have Shape Data #1120

KyroChi opened this issue Aug 15, 2024 · 3 comments · Fixed by #1122

Comments

@KyroChi
Copy link
Contributor

KyroChi commented Aug 15, 2024

As far as I can tell, the generation ix Pokémon do not have shape data.

See, for example:
https://pokeapi.co/api/v2/pokemon-species/906
https://pokeapi.co/api/v2/pokemon-species/907
https://pokeapi.co/api/v2/pokemon-species/908

@KyroChi KyroChi changed the title Sprigatito's Evolution Chain has "null" shape. Generation IX Pokémon do not Have Shape Data Aug 15, 2024
@Naramsim
Copy link
Member

Hello! Would you like to contribute and fill the data in? 💕

@KyroChi
Copy link
Contributor Author

KyroChi commented Aug 16, 2024

Sure! But I don't have much time to familiarize myself with your codebase. If you give me a high-level of what would need to be done I can debug and try to figure it out from there. 🙂

@Naramsim
Copy link
Member

Basically you should edit the lines for the pokemon species you are referring to and add the shape_id information. Shape_id can be found in the pokemon shape file most probably, but I haven't checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants