Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Resources #1

Closed
FallenDeity opened this issue Jan 12, 2024 · 6 comments
Closed

Adding Resources #1

FallenDeity opened this issue Jan 12, 2024 · 6 comments
Assignees
@FallenDeity

Comments

@FallenDeity
Copy link
Collaborator

So this repository is for storing the cries right @Naramsim following conventions of the sprites repository
@FallenDeity FallenDeity self-assigned this Jan 12, 2024
@Naramsim
Copy link
Member

yes, as described in the comment I made on the other issue you opened a while ago

@FallenDeity
Copy link
Collaborator Author

@Naramsim does the content format seem fine?

@Naramsim
Copy link
Member

Perfect! We can now add this repo as a submodule to the pokeapi one and start build the API

@Naramsim
Copy link
Member

Naramsim commented Feb 1, 2024

Hi, I added the repo as submodule to pokeapi

@FallenDeity
Copy link
Collaborator Author

FallenDeity commented Feb 1, 2024 •
edited
Loading

oh rip i already did that locally no issues I'll just pull the changes, I'll test out the changes in the api and make a pr by tomorrow i suppose been a bit busy past few days

@FallenDeity
Copy link
Collaborator Author

Completed with pr #1030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FallenDeity FallenDeity

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Naramsim @FallenDeity