Merge branch 'feat/update-dependencies' of github.com:PnX-SI/GeoNature into feat/update-dependencies

Author: Pierre-Narcisi

backend/geonature/tests/test_commands.py

@@ -11,12 +11,11 @@
 from geonature.utils.env import db
 from munch import Munch
 from pypnusershub.db.models import User
+import pytest
 
 from .fixtures import *
 
 # Reuse Lambda function in the following tests
-true = lambda: True
-false = lambda: False
 abs_function = lambda *args, **kwargs: None
 
 
@@ -86,123 +85,126 @@ def parents(self):
         return SequenceMock()
 
 
-def print_result(result):
-    """
-    Only for DEBUG test
-    """
-    print("---------")
-    print("Output")
-    print(result.output)
-    print("Exception")
-    print(result.exception)
-    print("---------")
+def patch_monkeypatch(monkeypatch):
+    monkeypatch.setattr(command_utils, "run", run_success_mock)
+    monkeypatch.setattr(install_module.subprocess, "run", run_success_mock)
+    monkeypatch.setattr(install_module, "Path", PathMock)
+
+    for (
+        method
+    ) in "module_db_upgrade build_frontend create_frontend_module_config install_frontend_dependencies".split():
+        monkeypatch.setattr(install_module, method, abs_function)
+    # Redefine os
+    monkeypatch.setattr(install_module.os.path, "exists", lambda x: True)
+    monkeypatch.setattr(install_module.os, "symlink", lambda x, y: None)
+    monkeypatch.setattr(install_module.os, "unlink", lambda x: None)
+    monkeypatch.setattr(install_module.os, "readlink", lambda x: None)
+    monkeypatch.setattr(install_module.importlib, "reload", abs_function)
 
 
+@pytest.fixture
+def client_click():
+    return CliRunner()
+
+
+@pytest.mark.usefixtures()
 class TestCommands:
-    def test_install_gn_module(self, monkeypatch):
-        """
-        Function to redefine
-
-        os.path.exists
-        subprocess.run
-        Path.is_file --> strict is always True
-        module_db_upgrade --> do nothing
-        """
-        logging.info("\nTEST INSTALL GN MODULE")
-        cli = CliRunner()
+    # Avoid redefine at each test
+    cli = CliRunner()
 
-        monkeypatch.setattr(command_utils, "run", run_success_mock)
-        monkeypatch.setattr(install_module.subprocess, "run", run_success_mock)
-        monkeypatch.setattr(install_module, "Path", PathMock)
-
-        for (
-            method
-        ) in "module_db_upgrade build_frontend create_frontend_module_config install_frontend_dependencies".split():
-            monkeypatch.setattr(install_module, method, abs_function)
-        # Redefine os
-        monkeypatch.setattr(install_module.os.path, "exists", lambda x: True)
-        monkeypatch.setattr(install_module.os, "symlink", lambda x, y: None)
-        monkeypatch.setattr(install_module.os, "unlink", lambda x: None)
-        monkeypatch.setattr(install_module.os, "readlink", lambda x: None)
-        monkeypatch.setattr(install_module.importlib, "reload", abs_function)
-
-        # module code
-        # 1. If module code
-        # 1.1 check that if module do not exist works
-        logging.info("Test: if module code not exists")
-        result = cli.invoke(install_module.install_gn_module, ["test/", "TEST"])
+    def test_install_gn_module_no_modulecode(self):
+        result = self.cli.invoke(install_module.install_gn_module, ["test/", "TEST"])
         assert isinstance(result.exception, Exception)
 
-        # 1.2 if get_dist_from_code is None
-        logging.info("Test : if get_dist_from_code() returns None")
+    def test_install_gn_module_dist_code_is_none(self, monkeypatch):
+        patch_monkeypatch(monkeypatch)
         monkeypatch.setattr(install_module, "get_dist_from_code", lambda x: None)
-        result = cli.invoke(install_module.install_gn_module, ["test/", "TEST"])
+        result = self.cli.invoke(install_module.install_gn_module, ["test/", "TEST"])
         assert result.exception.code > 0
 
-        # 1.2 if get_dist_from_code is GEONATURE
-        logging.info("Test : if get_dist_from_code() returns GEONATURE")
+    def test_install_gn_module_dist_code_is_GEONATURE(self, monkeypatch):
+        patch_monkeypatch(monkeypatch)
         monkeypatch.setattr(install_module, "get_dist_from_code", lambda x: "GEONATURE")
-        result = cli.invoke(install_module.install_gn_module, ["test/"])
+        result = self.cli.invoke(install_module.install_gn_module, ["test/"])
         assert result.exit_code == 0
 
-        # 2. If not module code given
-
-        logging.info("Test : no module code given")
+    def test_install_gn_module_no_module_code(self, monkeypatch):
+        patch_monkeypatch(monkeypatch)
         module_path = "backend/geonature/core"
         monkeypatch.setattr(
             install_module, "iter_modules_dist", iter_module_dist_mock("geonature")
         )
-        result = cli.invoke(install_module.install_gn_module, [module_path])
+        result = self.cli.invoke(install_module.install_gn_module, [module_path])
         assert result.exit_code == 0
 
-        logging.info("Test: if iter_modules_dist return an empty iterator")
+    def test_install_gn_module_empty_iter_module_dist(self, monkeypatch):
+        patch_monkeypatch(monkeypatch)
+        module_path = "backend/geonature/core"
         monkeypatch.setattr(install_module, "iter_modules_dist", lambda: [])
-        result = cli.invoke(install_module.install_gn_module, [module_path])
+        result = self.cli.invoke(install_module.install_gn_module, [module_path])
         assert result.exit_code > 0
         monkeypatch.setattr(
             install_module, "iter_modules_dist", iter_module_dist_mock("geonature")
         )
 
-        # 3. build parameter set to false
-        logging.info("Test : build parameter set to false")
-        result = cli.invoke(install_module.install_gn_module, [module_path, "--build=false"])
+    def test_install_gn_module_nomodule_code(self, monkeypatch):
+        patch_monkeypatch(monkeypatch)
+        module_path = "backend/geonature/core"
+        monkeypatch.setattr(
+            install_module, "iter_modules_dist", iter_module_dist_mock("geonature")
+        )
+        result = self.cli.invoke(install_module.install_gn_module, [module_path, "--build=false"])
         assert result.exit_code == 0
 
-        # 4. upgrade_db parameter set to false
-        logging.info("Test : upgrade_db parameter set to false")
-        result = cli.invoke(install_module.install_gn_module, [module_path, "--upgrade-db=false"])
+    def test_install_gn_module_false_upgrade_db(self, monkeypatch):
+        patch_monkeypatch(monkeypatch)
+        module_path = "backend/geonature/core"
+        monkeypatch.setattr(
+            install_module, "iter_modules_dist", iter_module_dist_mock("geonature")
+        )
+
+        result = self.cli.invoke(
+            install_module.install_gn_module, [module_path, "--upgrade-db=false"]
+        )
         assert result.exit_code == 0
 
-        logging.info("Test : if symlink not exists")
+    def test_install_gn_module_symlink_not_exists(self, monkeypatch):
+        patch_monkeypatch(monkeypatch)
+        module_path = "backend/geonature/core"
+        monkeypatch.setattr(
+            install_module, "iter_modules_dist", iter_module_dist_mock("geonature")
+        )
         monkeypatch.setattr(install_module.os.path, "exists", lambda x: False)
-        result = cli.invoke(install_module.install_gn_module, [module_path])
+        result = self.cli.invoke(install_module.install_gn_module, [module_path])
+
         assert result.exit_code == 0
 
-        logging.info("Test : if module not in sys.module")
+    def test_install_gn_module_module_notin_sysmodule(self, monkeypatch):
+        patch_monkeypatch(monkeypatch)
+        module_path = "backend/geonature/core"
         monkeypatch.setattr(install_module.os.path, "exists", lambda x: False)
         monkeypatch.setattr(install_module, "iter_modules_dist", iter_module_dist_mock("pouet"))
-        result = cli.invoke(install_module.install_gn_module, [module_path])
+        result = self.cli.invoke(install_module.install_gn_module, [module_path])
         assert result.exit_code > 0  # will fail
 
     def test_upgrade_modules_db(self, monkeypatch):
-        cli = CliRunner()
         monkeypatch.setattr(
             install_module, "iter_modules_dist", iter_module_dist_mock("geonature")
         )
-        result = cli.invoke(install_module.upgrade_modules_db, [])
+        result = self.cli.invoke(install_module.upgrade_modules_db, [])
         assert result.exit_code > 0
 
         with monkeypatch.context() as m:
             m.setitem(config, "DISABLED_MODULES", ["test"])
-            result = cli.invoke(install_module.upgrade_modules_db, ["test"])
+            result = self.cli.invoke(install_module.upgrade_modules_db, ["test"])
             assert result.exit_code == 0
 
         monkeypatch.setattr(install_module, "module_db_upgrade", lambda *args, **kwargs: True)
-        result = cli.invoke(install_module.upgrade_modules_db, ["test"])
+        result = self.cli.invoke(install_module.upgrade_modules_db, ["test"])
         assert result.exit_code == 0
 
         monkeypatch.setattr(install_module, "module_db_upgrade", lambda *args, **kwargs: False)
-        result = cli.invoke(install_module.upgrade_modules_db, ["test"])
+        result = self.cli.invoke(install_module.upgrade_modules_db, ["test"])
         assert result.exit_code == 0
 
     def test_nvm_available(self, monkeypatch):