Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] If you accidentally click multiple playlists, it is possible to open multiple of them #109

Open
LuisACorreaCSUMB opened this issue Apr 26, 2020 · 1 comment
Labels
🐛bug Something isn't working good first issue Good for newcomers hacktoberfest-accepted Accepted for Hacktoberfest

Comments

@LuisACorreaCSUMB
Copy link

This can make it hard to get back to the main menu as you will have to back out of every opened one

@adilanchian adilanchian added 🐛bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Apr 28, 2020
@adilanchian adilanchian changed the title If you accidentally click multiple playlists, it is possible to open multiple of them [Bug] If you accidentally click multiple playlists, it is possible to open multiple of them Apr 28, 2020
@adilanchian
Copy link
Collaborator

Repro Steps:

  1. Tap a playlist that has a larger amount of songs
  2. The app will probably hang at that moment
  3. While it hangs tap another playlist

Expected Results

The first playlist should only be loaded in

Actual Results

All playlists tapped are loaded in

Potential Solution

Change up the ordering of how we load in new data for each playlist. More so, navigate immediately to our playlist and throw some loading indicator on the songs list while they come in. Also, when a playlist is tapped, potentially set a flag that blocks all other playlists from being tapped.

@adilanchian adilanchian added hacktoberfest-accepted Accepted for Hacktoberfest and removed help wanted Extra attention is needed labels Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working good first issue Good for newcomers hacktoberfest-accepted Accepted for Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants