[imaging] make image extension case-insensitive #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we can use, ie, .PNG, .TIF, etc oiio already can handle this, and Glf_StbImage::_GetFilenameExtension() already converts to lowercase as well
spitzak
reviewed
Mar 20, 2019
| @@ -68,7 +68,8 @@ GlfImageRegistry::_ConstructImage(std::string const & filename) | |||
| static GlfImageSharedPtr NULL_IMAGE; | |||
|
|
|||
| // Lookup the plug-in type name based on the filename. | |||
| TfToken fileExtension(ArGetResolver().GetExtension(filename)); | |||
| TfToken fileExtension( | |||
| TfStringToLower(ArGetResolver().GetExtension(filename))); | |||
There was a problem hiding this comment.
It would be better to not change the case when printing the unknown image type error message. You could put to tolower in the call to Find(), or you could change the error message to print the entire filename (which is what the Python version is doing).
|
Filed as internal issue #USD-5169 |
|
Thanks for the fix @elrond79 -- we merged this and it should land in dev soon after 20.02 is released. In order to address @spitzak's excellent point, I added some extra debug output that gives the exact name of the file before any filtering, so hopefully that should address the review feedback. Thank you both. |
|
Great, thanks both! |
pixar-oss
added a commit
that referenced
this pull request
Feb 1, 2020
…tive [imaging] make image extension case-insensitive (Internal change: 2034668)
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
* remove hgi dependency from hio; * update webgpu baselines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
so we can use, ie, .PNG, .TIF, etc
oiio already can handle this, and Glf_StbImage::_GetFilenameExtension() already converts to lowercase as well
Fixes Issue(s)