[usdMaya] add filterTypes option to avoid exporting certain node types #475
Conversation
|
Filed as internal issue #160429. |
| // Unfortunately, the returned list will often include weird garbage, like | ||
| // "THconstraint" for "constraint", which cannot be converted to a MNodeClass, | ||
| // so just ignore these... | ||
| // MGlobal::displayError(MString("Given inherited excluded node type '") + inheritedTypes[i] |
There was a problem hiding this comment.
Is keeping this commented-out displayError call intentional?
There was a problem hiding this comment.
It was - I liked that it was sort of descriptive of what was going on, but it's not really necessary. I'll get rid of it.
| @@ -168,12 +171,30 @@ struct JobExportArgs | |||
| PXRUSDMAYA_API | |||
| static const VtDictionary& GetDefaultDictionary(); | |||
|
|
|||
| PXRUSDMAYA_API | |||
There was a problem hiding this comment.
For style consistency with the rest of the API, could these be "AddFilteredTypeName", "GetFilteredTypeIds", and "ClearFilteredTypeIds"?
There was a problem hiding this comment.
Also, could we add docs to AddFilteredTypeName about the inherited type behavior, e.g:
/// Adds type name to filter out during export. This will also add all
/// inherited types (so if you exclude "constraint", it will also exclude
/// "parentConstraint")
|
|
||
| // Maya type ids to avoid exporting; these are | ||
| // EXACT types, though the only exposed way to modify this, | ||
| // addFilteredTypeName, will also add all inherited types |
There was a problem hiding this comment.
Need to fix up this reference to addFilteredTypeName to AddFilteredTypeName per above
| // addFilteredTypeName, will also add all inherited types | ||
| // (so if you exclude "constraint", it will also exclude | ||
| // "parentConstraint") | ||
| std::set<unsigned int> filteredTypeIds; |
There was a problem hiding this comment.
Our coding style uses "_" as a prefix for private members, so could we rename this to _filteredTypeIds?
| @@ -142,6 +142,11 @@ global proc int usdTranslatorExport (string $parent, | |||
| checkBox -l "Export Visibility" exportVisibilityCheckBox; | |||
|
|
|||
| checkBox -l "Renderable Only" renderableOnlyCheckBox; | |||
|
|
|||
| textFieldGrp -l "Filtered Node Types" | |||
| -annotation ("Do not filter nodes of this type, or their children;\n" + | |||
There was a problem hiding this comment.
This annotation seems incorrect, should the description be something like "Filter out nodes of this type and their children" or "Do not import nodes of this type or their children"?
sunyab
added
the
blocked
|
Pushed updated commit addressing code review notes. Incremental changes are here: |
sunyab
added
pending push
and removed
blocked
|
Updated the PR to make it work with the latest usdMaya changes. |
[usdMaya] add filterTypes option to avoid exporting certain node types (Internal change: 1867883)
|
Merged this PR, closing! |
Description of Change(s)
Adds a new flag, "filterTypes", which allows you to avoid exporting nodes of certain maya node types.
This is handy for, ie, constraints, which are exported as transforms, but generally have no xform data of their own. Particularly nice if you use mergeTransformAndShape, and want to avoid having your camera renamed just because it has a constraint on it. (I would like to set filterTypes="constraint" by default, but this would technically break backwards compatibility. It seems unlikely anyone is relying on exporting the constraint nodes themselves, since all their useful data is NOT exported, but I suppose anything is possible...)
Likely also useful for other scenarios, as well (ie, maybe you don't want to export cameras, or place3dTexture nodes, etc)
Fixes Issue(s)