Fixes for calling into a USD library built with MSVC, from code built with clang-cl #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but that's fine because they're ABI compatible). A few source header adjustments that clang complained about: * pxr/base/tf/preprocessorUtils.h: Replace uses of ARCH_OS_WINDOWS with ARCH_COMPILER_MSVC because clang-cl's preprocessor is better. This fixes many compiler errors with the use of boost cpp. * pxr/usd/sdf/fileFormat.h: Remove SDF_API from "= delete" methods because it doesn't make sense to export deleted methods. I'm surprised that the other compilers allow this. * pxr/usd/ar/asset.h: Remove AR_API from "= delete" methods for same reason as previous. * pxr/base/arch/attributes.h: Fix ARCH_CONSTRUCTOR and ARCH_DESTRUCTOR. This issue only showed up when trying to use AR_DEFINE_RESOLVER() in client code and then noticing that it had failed to register the resolver because the ctor (and presumably the dtor as well) never gets called when the plugin library is loaded.
|
Filed as internal issue #USD-5792 |
pixar-oss
added a commit
that referenced
this pull request
Feb 11, 2020
Fixes for calling into a USD library built with MSVC, from code built with clang-cl (Internal change: 2039781)
|
Thank you, everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Submitting these changes on behalf of @e4lam.
From a clang-cl project that uses a pre-built USD library (with MSVC, but that's fine because they're ABI compatible). A few source header adjustments that clang complained about:
Fixes Issue(s)