build_usd.py can not find VS C++ compiler on non english systems #613
Comments
|
Filed as internal issue #USD-4727. |
|
Hi @ephb, thanks for the report! This might be as simple as modifying the regex to look for just the version number. We may also want to look for the "x64" string, since users should be using the x64 developer command prompt / compiler for building USD. |
|
@ephb, So how do u fix this? That would help me |
|
@Trafle This issue was fixed in 2019. If you're still running into problems please file a new issue with more details. Thank you! |
|
@sunyab gocha. Thank u |
francis-wangfr
pushed a commit
to autodesk-forks/USD
that referenced
this issue
Feb 8, 2024
…ixarAnimationStudios#613) - Use the glslang dependency included when getting tint/dawn dependencies - Update shaderCompiler.cpp to use glslang api instead of shaderc - Update build logic to account for change in dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of Issue
Line 99 ind build_usd.py uses the string to determine wether the c++ compiler is installed.
"Compiler Version (\d+).(\d+).(\d+)",
This is string however seems to be localized. And since I installed Visual Studio in English I assume this is taken from the system locale.
'cl' on my system returns 'Optimierungscompiler Version 19.15.26726 für x86'.
So in my case simply changing one letter in the search string is sufficient but I imagine this will also affect other languages this why I opened this issue instead of providing a pull request with two different strings.
I think there must be a better way than to simply list all possible names of the copmpiler.
Steps to Reproduce
System Information (OS, Hardware)
Windows 10 1803. Hardware seems to be irrelevant here.
Package Versions
18.09
Build Flags
none
The text was updated successfully, but these errors were encountered: