APPLE: Fix iOS not clearing background buffer when animating/navigating. #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an errant availability macro that was causing the path to be taken on only non-macOS platforms. This caused issues where the background would retain the previous background, causing a Solitaire win like effect. This patch makes the color pass use the same pattern as the depth pass, and adequately clear the background. Tested on iOS 18.3
|
Filed as internal issue #USD-10617 (This is an automated message. See here for more information.) |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
There was an errant availability macro that was causing the path to be taken on only non-macOS platforms. This caused issues where the background would retain the previous background, causing a Solitaire win like effect.
This patch makes the color pass use the same pattern as the depth pass, and adequately clear the background.
I believe this resolves to the same LoadAction, but something about the availability macro was causing an issue here.
Either way, at least it cleans it up.
Tested on iOS 18.3
Checklist
[X] I have created this PR based on the dev branch
[X] I have followed the coding conventions
[ ] I have added unit tests that exercise this functionality (Reference:
testing guidelines)
[X] I have verified that all unit tests pass with the proposed changes
[X] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)