Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(packages): revert the changes on offline packages about sync_diff_inspector tool for history versions #563

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

wuhuizuo
Copy link
Contributor

for v8.5.x and lower versions, we still release with the latest code from master branch.

…iff_inspector tool for history versions

for v8.5.x and lower versions, we still release with the latest code
from master branch.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from purelind February 27, 2025 10:50
Copy link

ti-chi-bot bot commented Feb 27, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Key Changes:

  • The pull request reverts the changes made on the sync_diff_inspector tool for history versions v8.5.x and lower in the offline-packages.yaml.tmpl file.
  • It updates the URL for the sync_diff_inspector tool to use the latest code from the master branch instead of specific versions for v8.5.x and lower.

Potential Problems:

  1. The description provided in the pull request does not seem to match the actual changes made in the code. The description mentions releasing with the latest code from the master branch for v8.5.x and lower versions, but the diff shows a revert of specific version references.
  2. It is not clear why the revert is being done for the sync_diff_inspector tool. There may be missing context or explanation for this change.

Fixing Suggestions:

  1. Update the pull request description to accurately reflect the changes made in the code. Provide a clear explanation for the revert action.
  2. Ensure that the reason for reverting the specific version references for the sync_diff_inspector tool is well-documented and justified in the pull request description.
  3. If the intention is to align with the latest code from the master branch for v8.5.x and lower versions, consider revising the implementation to reflect this intention clearly.

Overall, it is important to provide clear and consistent information in the pull request description to help reviewers understand the purpose of the changes made.

@ti-chi-bot ti-chi-bot bot added the size/M label Feb 27, 2025
@wuhuizuo
Copy link
Contributor Author

/cc @Benjamin2037

PTAL

@ti-chi-bot ti-chi-bot bot requested a review from Benjamin2037 February 27, 2025 10:50
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 27, 2025
@ti-chi-bot ti-chi-bot bot merged commit c904896 into main Feb 27, 2025
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/use-latest-tidb-tools-for-lts-branches branch February 27, 2025 11:24
Copy link

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants