Fix Python install #122
Merged
Fix Python install #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the install behavior for colcon build. Now both symlink and non-symlink install correctly and can be imported. Also, I changed the
admittance_parameters import admittance_controllertogenerate_parameter_module_example.admittance_parameters import admittance_controller. I believe it's better this way to avoid cluttering the Python namespace.There is an unfortunate side effect to installing with symlink. Since the install location is linked to the source, the generated code appears in the project's source code. I don't know if there is any way around this.