Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Chore(types): added typings field to export type information #23

Merged
merged 1 commit into from
Dec 21, 2019

Conversation

fhyoga
Copy link
Contributor

@fhyoga fhyoga commented Dec 21, 2019

导出类型信息,在开发插件或者其他场景得到类型提示
image

@Molunerfinn
Copy link
Member

其实PicGo的导出包不需要这个字段也能有TS的提示。不过加上也是OK的。

另外提示一下:
image
插件开发的时候,picgo请安装在dev依赖里,否则最终打包的插件体积会将picgo-core再打包一份,但是实际上PicGo本身就有一份picgo-core,并且插件能调用的ctx全部来自PicGo本身,所以不需要将picgo-core安装在dep里,装在dev里在开发阶段能有提示,在生产阶段能减少体积

@Molunerfinn Molunerfinn merged commit 8bb16e7 into PicGo:dev Dec 21, 2019
@Molunerfinn
Copy link
Member

感谢贡献!

fhyoga added a commit to fhyoga/PicGo-Core that referenced this pull request Dec 26, 2019
📦 Chore(types): added typings field to export type inform… (PicGo#23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants