Removed -st from .perltidyrc (that is surely an uncontroversial improvement...)

Tidied everything using the reverted .perltidyrc.

Author: AndyA

.perltidyrc

@@ -2,7 +2,6 @@
 -l=78  # max line width is 78 columns
 -i=4   # indent level is 4 columns
 -ci=2  # continuation indent is 2 columns
--st    # output to STDOUT
 -se    # errors to STDERR
 -vt=2  # minimum vertical tightness
 -cti=0 # no extra indentation for closing brackets

Build.PL

@@ -3,7 +3,7 @@ use Module::Build;
 use 5.005;
 
 use File::Spec;
-use lib 'inc', File::Spec->canonpath('lib/');  # use our self to install
+use lib 'inc', File::Spec->canonpath('lib/');    # use our self to install
 
 use MyBuilder;
 

benchmark/by_stage.pl

@@ -58,8 +58,7 @@
                 {
                     my $delta = $cur_time - $base_time;
                     my $color
-                      = (
-                        abs($delta) > ( $cur_time + $base_time ) / 50 )
+                      = ( abs($delta) > ( $cur_time + $base_time ) / 50 )
                       ? ( $delta > 0 )
                           ? RED
                           : GREEN

benchmark/historical.pl

@@ -89,8 +89,7 @@
     my @lines = split( /\n/, $data );
 
     # the last (only) yaml marker
-    my @markers
-      = grep( { $lines[$_] =~ m/^---(?:\s|$)/ } 0 .. $#lines );
+    my @markers = grep( { $lines[$_] =~ m/^---(?:\s|$)/ } 0 .. $#lines );
     my @yaml = map( { $lines[$_] } $markers[-1] .. $#lines );
     my ($hash) = YAML::Load( join( "\n", @yaml, '' ) );
     if ( $rev eq 'prove' ) {
@@ -172,8 +171,8 @@
 sub check_cache {
     my ($cached_file) = @_;
     if ( -e $cached_file ) {
-        open( my $fh, '<', $cached_file ) or
-          die "cannot open cache $cached_file $!";
+        open( my $fh, '<', $cached_file )
+          or die "cannot open cache $cached_file $!";
         my $data = do { local $/; <$fh> };
         return ($data);
     }
@@ -191,19 +190,18 @@ sub run_rev {
     IPC::Run::run(
         [@command],
         '>' =>
-          sub { $out .= join( '', @_ ); print $fh @_; print @_ },  # tee
+          sub { $out .= join( '', @_ ); print $fh @_; print @_ },    # tee
         '2>' => \$err,
-      ) or
-      die "now what $? $! $err";
+    )               or die "now what $? $! $err";
     chdir($basedir) or die $!;
     return ($out);
 }
 
 sub do_svn {
     my @command = @_;
     $ENV{NOSVN} and return;
-    system( 'svn', @command ) and
-      die "svn @command failed $? $!";
+    system( 'svn', @command )
+      and die "svn @command failed $? $!";
 }
 
 # vim:ts=4:sw=4:et:sta

benchmark/prove_vs_runtests-raw.pl

@@ -30,8 +30,7 @@
     'named!',
     'prove!',
     'runtests!',
-  ) or
-  die "bad options";
+) or die "bad options";
 
 if (0) {    # header
     my @mods = qw(
@@ -55,30 +54,32 @@
 
 # for historical benchmarks
 # (because we renamed this, but had both once)
-my $prove_or_runtests
-  = ( -e 'bin/runtests' ? 'bin/runtests' : 'bin/prove' );
+my $prove_or_runtests = ( -e 'bin/runtests' ? 'bin/runtests' : 'bin/prove' );
 
 my $tmp_dir = File::Temp::tempdir(
     'tapx-' . 'X' x 8,
     TMPDIR  => 1,
     CLEANUP => 1,
-  ) .
-  '/';
+) . '/';
 
 my $pwd = Cwd::getcwd();
 chdir($tmp_dir) or die "cannot get into $tmp_dir $!";
 mkdir('t')      or die "cannot create t directory $!";
 
 # just checking raw output handling speed
 my $thetest
-  = 'my $n = ' . $knobs{num_lines} . ';' . q(print "1..$n\n";) .
-  q(print "ok $_) . ( $knobs{named} ? ' whee' : '' ) .
-  q(\n" for (1..$n);) . q(# print "#$0";);
+  = 'my $n = '
+  . $knobs{num_lines} . ';'
+  . q(print "1..$n\n";)
+  . q(print "ok $_)
+  . ( $knobs{named} ? ' whee' : '' )
+  . q(\n" for (1..$n);)
+  . q(# print "#$0";);
 
 for my $num ( 1 .. $knobs{num_test_files} ) {
     my $testfile = sprintf( 't/%02d-test.t', $num );
-    open( my $fh, '>', $testfile ) or
-      die "cannot open '$testfile' for writing $!";
+    open( my $fh, '>', $testfile )
+      or die "cannot open '$testfile' for writing $!";
     print $fh $thetest;
 }
 
@@ -132,8 +133,7 @@ sub time_this {
 }
 
 my $res = {
-    (   $knobs{prove}
-        ? time_this( prove => sub { system(@prove) and die; } )
+    (   $knobs{prove} ? time_this( prove => sub { system(@prove) and die; } )
         : ()
     ),
     (   $knobs{runtests}

examples/bin/tprove_gtk

@@ -36,8 +36,10 @@ if (@ARGV) {
     @tests = @ARGV;
 }
 else {
-    find( sub { -f && /\.t$/ && push @tests => $File::Find::name },
-        "t" );
+    find(
+        sub { -f && /\.t$/ && push @tests => $File::Find::name },
+        "t"
+    );
 }
 
 pipe( my $reader, my $writer );
@@ -206,12 +208,12 @@ sub create_view {
 
     my $model = Gtk2::ListStore->new(
 
-  #  filename     total     run       pass      fail      skip      todo
+        #  filename     total     run       pass      fail      skip      todo
         qw(Glib::String Glib::Int Glib::Int Glib::Int Glib::Int Glib::Int Glib::Int)
     );
     my $view = Gtk2::TreeView->new($model);
 
-# ------------------------------------------------------------------------- #
+ # ------------------------------------------------------------------------- #
 
     my $column_filename = Gtk2::TreeViewColumn->new_with_attributes(
         "Filename",
@@ -222,7 +224,7 @@ sub create_view {
     $column_filename->set_expand(TRUE);
     $view->append_column($column_filename);
 
-# ------------------------------------------------------------------------- #
+ # ------------------------------------------------------------------------- #
 
     my $renderer_progress = Gtk2::CellRendererProgress->new();
     my $column_progress   = Gtk2::TreeViewColumn->new_with_attributes(
@@ -261,7 +263,7 @@ sub create_view {
     );
     $view->append_column($column_progress);
 
-# ------------------------------------------------------------------------- #
+ # ------------------------------------------------------------------------- #
 
     my @count_columns = (
         [ "Pass", COLUMN_PASS ],
@@ -285,7 +287,7 @@ sub create_view {
         $view->append_column($column);
     }
 
-# ------------------------------------------------------------------------- #
+ # ------------------------------------------------------------------------- #
 
     $scroller->add($view);
     $vbox->pack_start( $scroller, TRUE, TRUE, 0 );
@@ -310,8 +312,7 @@ sub _callback_reader {
     if ( $condition & "in" || $condition & "pri" ) {
         my $data = <$reader>;
 
-        if ( $data !~
-            /^[^\t]+ \t \d+ \t \d+ \t \d+ \t \d+ \t \d+ \t \d+$/x )
+        if ( $data !~ /^[^\t]+ \t \d+ \t \d+ \t \d+ \t \d+ \t \d+ \t \d+$/x )
         {
             return TRUE;
         }
@@ -461,8 +462,9 @@ sub analyze {
         }
 
         else {
-            warn "Unknown result type `" . $line->type() . "´: " .
-              $line->as_string();
+            warn "Unknown result type `"
+              . $line->type() . "´: "
+              . $line->as_string();
         }
 
         my $string = join "\t", $test, @{$result};

lib/App/Prove.pm

@@ -136,8 +136,7 @@ sub process_args {
                 ? App::Prove::Plugins->switches
                 : ()
             ),
-          ) or
-          croak('Unable to continue');
+        ) or croak('Unable to continue');
 
         # Stash the remainder of argv for later
         $self->{argv} = [@ARGV];
@@ -155,8 +154,9 @@ sub _help {
     # XXX Getopt::Long is being helpy
     local $SIG{__DIE__} = sub { warn @_; $self->_exit; };
     if ($err) {
-        die 'Please install Pod::Usage for the --help option ' .
-          '(or try `perldoc prove`.)' . "\n ($@)";
+        die 'Please install Pod::Usage for the --help option '
+          . '(or try `perldoc prove`.)'
+          . "\n ($@)";
     }
 
     Pod::Usage::pod2usage( { -verbose => 1 } );
@@ -184,7 +184,7 @@ sub _get_args {
     }
 
     if ( $self->archive ) {
-        eval("sub TAP::Harness::Archive::auto_inherit {1}"); # wink,wink
+        eval("sub TAP::Harness::Archive::auto_inherit {1}");    # wink,wink
         $self->require_harness( archive => 'TAP::Harness::Archive' );
         $args{archive} = $self->archive;
     }
@@ -235,8 +235,7 @@ sub _get_args {
 
     $args{errors} = 1 if $self->parse;
 
-    $args{exec}
-      = length( $self->exec ) ? [ split( / /, $self->exec ) ] : []
+    $args{exec} = length( $self->exec ) ? [ split( / /, $self->exec ) ] : []
       if ( defined( $self->exec ) );
 
     if ($formatter_class) {

lib/TAP/Base.pm

@@ -66,9 +66,7 @@ sub _initialize {
     $self->{ok_callbacks} = \%ok_map;
 
     if ( exists $arg_for->{callbacks} ) {
-        while ( my ( $event, $callback )
-            = each %{ $arg_for->{callbacks} } )
-        {
+        while ( my ( $event, $callback ) = each %{ $arg_for->{callbacks} } ) {
             $self->callback( $event, $callback );
         }
     }
@@ -90,9 +88,8 @@ sub callback {
     $self->_croak('No callbacks may be installed')
       unless %ok_map;
 
-    $self->_croak(
-        "Callback $event is not supported. Valid callbacks are " .
-          join( ', ', sort keys %ok_map ) )
+    $self->_croak( "Callback $event is not supported. Valid callbacks are "
+          . join( ', ', sort keys %ok_map ) )
       unless exists $ok_map{$event};
 
     push @{ $self->{code_for}{$event} }, $callback;

lib/TAP/Formatter/Console.pm

@@ -22,8 +22,8 @@ BEGIN {
         stdout => sub {
             my ( $self, $ref ) = @_;
             $self->_croak("option 'stdout' needs a filehandle")
-              unless ( ref $ref || '' ) eq 'GLOB' or
-              eval { $ref->can('print') };
+              unless ( ref $ref || '' ) eq 'GLOB'
+              or eval { $ref->can('print') };
             return $ref;
         },
     );
@@ -78,13 +78,12 @@ sub _initialize {
     # Handle legacy verbose, quiet, really_quiet flags
     my %verb_map = ( verbose => 1, quiet => -1, really_quiet => -2, );
 
-    my @verb_adj
-      = grep {$_} map { delete $arg_for{$_} ? $verb_map{$_} : 0 }
+    my @verb_adj = grep {$_} map { delete $arg_for{$_} ? $verb_map{$_} : 0 }
       keys %verb_map;
 
     $self->_croak(
-        'Only one of verbose, quiet or really_quiet should be specified'
-    ) if @verb_adj > 1;
+        'Only one of verbose, quiet or really_quiet should be specified' )
+      if @verb_adj > 1;
 
     $self->verbosity( shift @verb_adj || 0 );
 
@@ -308,22 +307,22 @@ sub summary {
                 "  TODO passed:   ", $test, $parser
             );
 
-      # ~TODO this cannot be the default
-      #$self->_output_summary_failure( 'skipped', "  Tests skipped: " );
+            # ~TODO this cannot be the default
+            #$self->_output_summary_failure( 'skipped', "  Tests skipped: " );
 
             if ( my $exit = $parser->exit ) {
                 $self->_summary_test_header( $test, $parser );
-                $self->_failure_output(
-                    "  Non-zero exit status: $exit\n");
+                $self->_failure_output("  Non-zero exit status: $exit\n");
             }
 
             if ( my @errors = $parser->parse_errors ) {
                 my $explain;
                 if ( @errors > $MAX_ERRORS && !$self->errors ) {
                     $explain
-                      = "Displayed the first $MAX_ERRORS of " .
-                      scalar(@errors) . " TAP syntax errors.\n" .
-                      "Re-run prove with the -p option to see them all.\n";
+                      = "Displayed the first $MAX_ERRORS of "
+                      . scalar(@errors)
+                      . " TAP syntax errors.\n"
+                      . "Re-run prove with the -p option to see them all.\n";
                     splice @errors, $MAX_ERRORS;
                 }
                 $self->_summary_test_header( $test, $parser );

lib/TAP/Formatter/Console/ParallelSession.pm

@@ -108,7 +108,9 @@ sub _clear_line {
 sub _output_ruler {
     my $self      = shift;
     my $formatter = $self->formatter;
-    my $context   = $shared{$formatter};
+    return if $formatter->really_quiet;
+
+    my $context = $shared{$formatter};
 
     # Too much boilerplate!
     my $ruler = sprintf( "===( %7d )", $context->{tests} );
@@ -136,8 +138,9 @@ sub result {
 
     if ( $result->is_bailout ) {
         $formatter->_failure_output(
-            "Bailout called.  Further testing stopped:  " .
-              $result->explanation . "\n" );
+                "Bailout called.  Further testing stopped:  "
+              . $result->explanation
+              . "\n" );
     }
 
     # $self->_plan( '/' . ( $planned || 0 ) . ' ' ) unless $self->_plan;
@@ -200,10 +203,15 @@ sub close_test {
     my $formatter = $self->formatter;
     my $context   = $shared{$formatter};
 
-    $self->_clear_line;
+    unless ( $formatter->really_quiet ) {
+        $self->_clear_line;
 
-    # my $output = $self->_output_method;
-    $formatter->_output( $formatter->_format_name( $self->name ), ' ' );
+        # my $output = $self->_output_method;
+        $formatter->_output(
+            $formatter->_format_name( $self->name ),
+            ' '
+        );
+    }
 
     if ( $parser->has_problems ) {
         $self->_output_test_failure($parser);