Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GCC for macOS wheels/tests #299

Open
chaeyeunpark opened this issue Jun 2, 2022 · 1 comment
Open

Use GCC for macOS wheels/tests #299

chaeyeunpark opened this issue Jun 2, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@chaeyeunpark
Copy link
Contributor

As Lightning compiled with GCC is better performing than with Clang, it is better to use GCC for building wheels for macOS. In addition, GCC supports new C++20/23 functionalities better. Still, for robustness, we may have a Clang test in CI.
@chaeyeunpark chaeyeunpark added the enhancement New feature or request label Jun 2, 2022
@mlxd
Copy link
Member

mlxd commented Jun 15, 2022 •
edited
Loading

Note: Due to how we now build for ARM on MacOS as in pr #306, GCC may complicate matters. We may need to await for M1 Action runners for this to be fully possible without cross-compilations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlxd @chaeyeunpark