Skip to content

Commit d165de1

Browse files
Do not run cpp tests on schedule (compat tests). (#571)
* Do not run cpp tests on workflow_call (compat tests). * echo github.event_name * workflow_call => workflow_dispatch * Try contains(fromJSON * Fix contains(fromJSON * Fix contains(fromJSON * update changelog * Auto update version * trigger ci --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com>
1 parent a8f5f9f commit d165de1

File tree

6 files changed

+30
-14
lines changed

6 files changed

+30
-14
lines changed

.github/CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@
5151

5252
### Bug fixes
5353

54+
* Do not run C++ tests when testing for compatibility with PennyLane, hence fixing plugin-matrix failures. Fix Lightning-GPU workflow trigger.
55+
[(#571)](https://github.com/PennyLaneAI/pennylane-lightning/pull/571)
56+
5457
* Revert single-node multi-GPU batching behaviour to match https://github.com/PennyLaneAI/pennylane-lightning-gpu/pull/27.
5558
[(#564)](https://github.com/PennyLaneAI/pennylane-lightning/pull/564)
5659

.github/workflows/tests_gpu_cu11.yml

+6-5
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
name: Testing::Linux::x86_64::LGPU
22
on:
3-
workflow_run:
4-
workflows: ["Testing::LKokkos::CUDA"]
5-
types:
6-
- completed
73
workflow_call:
84
inputs:
95
lightning-version:
@@ -14,6 +10,11 @@ on:
1410
type: string
1511
required: true
1612
description: The version of PennyLane to use. Valid values are either 'release' (most recent release candidate), 'stable' (most recent git-tag) or 'latest' (most recent commit from master)
13+
release:
14+
pull_request:
15+
push:
16+
branches:
17+
- master
1718

1819
env:
1920
CI_CUDA_ARCH: 86
@@ -51,7 +52,7 @@ jobs:
5152
nvidia-smi
5253
5354
cpptestswithLGPU_cu11:
54-
if: ${{ !contains(fromJSON('["workflow_call"]'), github.event_name) }}
55+
if: ${{ !contains(fromJSON('["schedule", "workflow_dispatch"]'), github.event_name) }}
5556
needs: [builddeps]
5657
strategy:
5758
matrix:

.github/workflows/tests_linux.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ concurrency:
2828

2929
jobs:
3030
cpptests:
31-
if: ${{ !contains(fromJSON('["workflow_call"]'), github.event_name) }}
31+
if: ${{ !contains(fromJSON('["schedule", "workflow_dispatch"]'), github.event_name) }}
3232
strategy:
3333
matrix:
3434
os: [ubuntu-22.04]
@@ -47,7 +47,7 @@ jobs:
4747
uses: actions/checkout@v3
4848

4949
- name: Install dependencies
50-
run: sudo apt-get update && sudo apt-get -y -q install cmake gcc-$GCC_VERSION g++-$GCC_VERSION ninja-build gcovr lcov
50+
run: echo ${{ github.event_name }} && sudo apt-get update && sudo apt-get -y -q install cmake gcc-$GCC_VERSION g++-$GCC_VERSION ninja-build gcovr lcov
5151

5252
- name: Build and run unit tests
5353
run: |
@@ -177,7 +177,7 @@ jobs:
177177
if-no-files-found: error
178178

179179
cpptestswithOpenBLAS:
180-
if: ${{ !contains(fromJSON('["workflow_call"]'), github.event_name) }}
180+
if: ${{ !contains(fromJSON('["schedule", "workflow_dispatch"]'), github.event_name) }}
181181
strategy:
182182
matrix:
183183
os: [ubuntu-22.04]
@@ -333,7 +333,7 @@ jobs:
333333
os: ubuntu-22.04
334334

335335
cpptestswithKokkos:
336-
if: ${{ !contains(fromJSON('["workflow_call"]'), github.event_name) }}
336+
if: ${{ !contains(fromJSON('["schedule", "workflow_dispatch"]'), github.event_name) }}
337337
needs: [build_and_cache_Kokkos]
338338
strategy:
339339
matrix:
@@ -585,7 +585,7 @@ jobs:
585585

586586
cpptestsWithMultipleBackends:
587587
# Device-specific tests are performed for both. Device-agnostic tests default to LightningQubit.
588-
if: ${{ !contains(fromJSON('["workflow_call"]'), github.event_name) }}
588+
if: ${{ !contains(fromJSON('["schedule", "workflow_dispatch"]'), github.event_name) }}
589589
needs: [build_and_cache_Kokkos]
590590
strategy:
591591
matrix:

.github/workflows/tests_linux_x86_mpi_gpu.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ concurrency:
2828

2929
jobs:
3030
cpp_tests:
31-
if: ${{ contains(github.event.pull_request.labels.*.name, 'ci:use-multi-gpu-runner') && !contains(fromJSON('["workflow_call"]'), github.event_name) }}
31+
if: ${{ contains(github.event.pull_request.labels.*.name, 'ci:use-multi-gpu-runner') && !contains(fromJSON('["schedule", "workflow_dispatch"]'), github.event_name) }}
3232
runs-on:
3333
- self-hosted
3434
- linux
@@ -158,7 +158,7 @@ jobs:
158158
159159
160160
python_tests:
161-
if: ${{ contains(github.event.pull_request.labels.*.name, 'ci:use-multi-gpu-runner') || contains(fromJSON('["workflow_call"]'), github.event_name) }}
161+
if: ${{ contains(github.event.pull_request.labels.*.name, 'ci:use-multi-gpu-runner') || contains(fromJSON('["schedule", "workflow_dispatch"]'), github.event_name) }}
162162
runs-on:
163163
- self-hosted
164164
- linux

.github/workflows/tests_windows.yml

+13-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
name: Testing (Windows)
22
on:
3+
workflow_call:
4+
inputs:
5+
lightning-version:
6+
type: string
7+
required: true
8+
description: The version of Lightning to use. Valid values are either 'release' (most recent release candidate), 'stable' (most recent git-tag) or 'latest' (most recent commit from master)
9+
pennylane-version:
10+
type: string
11+
required: true
12+
description: The version of PennyLane to use. Valid values are either 'release' (most recent release candidate), 'stable' (most recent git-tag) or 'latest' (most recent commit from master)
313
push:
414
branches:
515
- master
@@ -11,6 +21,7 @@ concurrency:
1121

1222
jobs:
1323
cpptests:
24+
if: ${{ !contains(fromJSON('["schedule", "workflow_dispatch"]'), github.event_name) }}
1425
timeout-minutes: 30
1526
name: C++ tests (Windows)
1627
runs-on: ${{ matrix.os }}
@@ -144,11 +155,12 @@ jobs:
144155
cmake --install ./Build --config Debug --verbose
145156
146157
cpptestswithkokkos:
158+
if: ${{ !contains(fromJSON('["schedule", "workflow_dispatch"]'), github.event_name) }}
147159
needs: [build_dependencies, win-set-matrix-x86]
148160
strategy:
149161
matrix:
150162
os: [windows-latest]
151-
pl_backend: ["lightning_qubit"]
163+
pl_backend: ["lightning_kokkos"]
152164
exec_model: ${{ fromJson(needs.win-set-matrix-x86.outputs.exec_model) }}
153165
kokkos_version: ${{ fromJson(needs.win-set-matrix-x86.outputs.kokkos_version) }}
154166

pennylane_lightning/core/_version.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@
1616
Version number (major.minor.patch[-label])
1717
"""
1818

19-
__version__ = "0.34.0-dev13"
19+
__version__ = "0.34.0-dev14"

0 commit comments

Comments
 (0)