Uniform Python format to adhere PL style; Always decompose qml.QFT in Lightning (#924)

Please complete the following checklist when submitting a PR:

- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [ ] Ensure that the test suite passes, by running `make test`.

- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [ ] Ensure that code is properly formatted by running `make format`.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

------------------------------------------------------------------------------------------------------------

**Context:**

**Description of the Change:**

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**
[sc-74415]

---------

Co-authored-by: ringo-but-quantum <[email protected]>

Author: 2 people

.github/CHANGELOG.md

@@ -34,6 +34,12 @@
 
 ### Improvements
 
+* Always decompose `qml.QFT` in Lightning.
+  [(#924)](https://github.com/PennyLaneAI/pennylane-lightning/pull/924)
+
+* Uniform Python format to adhere PennyLane style.
+  [(#924)](https://github.com/PennyLaneAI/pennylane-lightning/pull/924)
+
 * Remove dynamic decomposition rules in Lightning.
   [(#926)](https://github.com/PennyLaneAI/pennylane-lightning/pull/926)
 

.github/workflows/format.yml

@@ -17,14 +17,14 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
-          python-version: '3.11'
+          python-version: '3.12'
 
       - name: Checkout PennyLane-Lightning
         uses: actions/checkout@v4
 
       - name: Install dependencies
         run:
-            python -m pip install -r requirements-dev.txt
+            python -m pip install -r requirements.txt
 
       - name: Run isort & black --check
         run: make format-python check=1 verbose=1
@@ -38,7 +38,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Install dependencies
-        run: sudo apt update && sudo apt -y install python3 python3-pip python-is-python3 && python -m pip install -r requirements-dev.txt
+        run: sudo apt update && sudo apt -y install python3 python3-pip python-is-python3 && python -m pip install -r requirements.txt
 
       - name: Run formatter
         run: PATH=$PATH:/home/ubuntu/.local/bin/:$(dirname $(which python3))/ ./bin/format --check ./pennylane_lightning/core/src

Makefile

@@ -131,8 +131,8 @@ format-cpp:
 	./bin/format $(CHECK) ./pennylane_lightning
 
 format-python:
-	isort --py 311 --profile black -l 100 -p pennylane_lightning ./pennylane_lightning ./mpitests ./tests ./scripts $(ICHECK) $(VERBOSE)
-	black -l 100 ./pennylane_lightning ./mpitests ./tests ./scripts $(CHECK) $(VERBOSE)
+	isort --py 312 --profile black -l 100 -p pennylane_lightning ./pennylane_lightning ./mpitests ./tests ./scripts $(ICHECK) $(VERBOSE)
+	black -t py310 -t py311 -t py312 -l 100 ./pennylane_lightning ./mpitests ./tests ./scripts $(CHECK) $(VERBOSE)
 
 .PHONY: check-tidy
 check-tidy:

pennylane_lightning/core/_state_vector_base.py

@@ -38,7 +38,6 @@ class LightningBaseStateVector(ABC):
     """
 
     def __init__(self, num_wires: int, dtype: Union[np.complex128, np.complex64]):
-
         if dtype not in [np.complex64, np.complex128]:
             raise TypeError(f"Unsupported complex type: {dtype}")
 

pennylane_lightning/core/_version.py

@@ -16,4 +16,4 @@
    Version number (major.minor.patch[-label])
 """
 
-__version__ = "0.39.0-dev35"
+__version__ = "0.39.0-dev34"

pennylane_lightning/lightning_gpu/lightning_gpu.py

@@ -172,7 +172,6 @@ def _mebibytesToBytes(mebibytes):
     "QubitCarry",
     "QubitSum",
     "OrbitalRotation",
-    "QFT",
     "ECR",
     "BlockEncode",
     "C(BlockEncode)",

pennylane_lightning/lightning_gpu/lightning_gpu.toml

@@ -50,7 +50,6 @@ GlobalPhase            = { properties = [ "differentiable" ] }
 [operators.gates.decomp]
 
 BasisState             = {}
-QFT                    = {}
 QubitStateVector       = {}
 StatePrep              = {}
 MultiControlledX       = {}

pennylane_lightning/lightning_kokkos/_measurements.py

@@ -46,7 +46,6 @@ def __init__(
         self,
         kokkos_state,
     ) -> None:
-
         super().__init__(kokkos_state)
 
         self._measurement_lightning = self._measurement_dtype()(kokkos_state.state_vector)

pennylane_lightning/lightning_kokkos/_state_vector.py

@@ -64,7 +64,6 @@ def __init__(
         kokkos_args=None,
         sync=True,
     ):  # pylint: disable=too-many-arguments
-
         super().__init__(num_wires, dtype)
 
         self._device_name = "lightning.kokkos"
@@ -280,7 +279,6 @@ def _apply_lightning(
             elif isinstance(operation, qml.ops.Controlled) and isinstance(
                 operation.base, qml.GlobalPhase
             ):  # apply n-controlled gate
-
                 # Kokkos do not support the controlled gates except for GlobalPhase
                 self._apply_lightning_controlled(operation)
             else:  # apply gate as a matrix

pennylane_lightning/lightning_kokkos/lightning_kokkos.py

@@ -120,7 +120,6 @@
         "QubitCarry",
         "QubitSum",
         "OrbitalRotation",
-        "QFT",
         "ECR",
         "BlockEncode",
         "C(BlockEncode)",

pennylane_lightning/lightning_kokkos/lightning_kokkos.toml

@@ -50,7 +50,6 @@ T                      = { properties = [ "invertible",                 "differe
 
 BasisState             = {}
 MultiControlledX       = {}
-QFT                    = {}
 QubitStateVector       = {}
 StatePrep              = {}
 ControlledQubitUnitary = {}

pennylane_lightning/lightning_qubit/_measurements.py

@@ -58,7 +58,6 @@ def __init__(
         kernel_name: str = None,
         num_burnin: int = None,
     ) -> None:
-
         super().__init__(qubit_state)
 
         self._mcmc = mcmc

pennylane_lightning/lightning_qubit/_state_vector.py

@@ -51,7 +51,6 @@ class LightningStateVector(LightningBaseStateVector):  # pylint: disable=too-few
     """
 
     def __init__(self, num_wires, dtype=np.complex128):
-
         super().__init__(num_wires, dtype)
 
         self._device_name = "lightning.qubit"

pennylane_lightning/lightning_qubit/lightning_qubit.py

@@ -139,7 +139,6 @@
         "QubitCarry",
         "QubitSum",
         "OrbitalRotation",
-        "QFT",
         "ECR",
         "BlockEncode",
         "C(BlockEncode)",

pennylane_lightning/lightning_qubit/lightning_qubit.toml

@@ -47,7 +47,6 @@ T                      = { properties = [ "invertible", "controllable", "differe
 # default, but can be useful to express a deviation from this device's regular
 # strategy in PennyLane.
 MultiControlledX       = {}
-QFT                    = {}
 
 # Gates which should be translated to QubitUnitary
 [operators.gates.matrix]

pennylane_lightning/lightning_tensor/lightning_tensor.py

@@ -140,7 +140,6 @@
         "QubitCarry",
         "QubitSum",
         "OrbitalRotation",
-        "QFT",
         "ECR",
         "BlockEncode",
         "C(BlockEncode)",

requirements-dev.txt

@@ -1,22 +1,21 @@
-git+https://github.com/PennyLaneAI/pennylane.git@master
 build
 ninja
-flaky
 pybind11
-pytest~=8.0.0
+pre-commit>=2.19.0
+pytest>=7.1.2
 pytest-benchmark
-pytest-cov
-pytest-mock
+pytest-cov>=3.0.0
+pytest-mock>=3.7.0
+pytest-xdist>=2.5.0
 pytest-split
-pytest-xdist
-pre-commit>=2.19.0
-black==24.3.0
+flaky>=3.7.0
+black>=21
 clang-tidy~=16.0
 clang-format~=16.0
 isort==5.13.2
 click==8.0.4
 cmake
 custatevec-cu12
 cutensornet-cu12
-pylint
-scipy
+pylint==2.7.4
+git+https://github.com/PennyLaneAI/pennylane.git@master

requirements-tests.txt

@@ -1,7 +1,7 @@
-pytest~=8.0.0
+pytest>=7.1.2
 pytest-benchmark
-pytest-cov
-pytest-mock
-pytest-xdist
-flaky
-git+https://github.com/PennyLaneAI/pennylane.git@master
+pytest-cov>=3.0.0
+pytest-mock>=3.7.0
+pytest-xdist>=2.5.0
+flaky>=3.7.0
+git+https://github.com/PennyLaneAI/pennylane.git@master

requirements.txt

@@ -1,9 +1,13 @@
 ninja
-flaky
-pennylane>=0.34
 pybind11
-pytest~=8.0.0
-pytest-cov
-pytest-mock
-scipy
-pytest-xdist
+pytest>=7.1.2
+pytest-cov>=3.0.0
+pytest-mock>=3.7.0
+pytest-xdist>=2.5.0
+flaky>=3.7.0
+black>=21
+clang-tidy~=16.0
+clang-format~=16.0
+isort==5.13.2
+pylint==2.7.4
+pennylane>=0.37

tests/lightning_qubit/test_jacobian_method.py

@@ -51,7 +51,6 @@ def calculate_reference(tape, execute_and_derivatives=False):
 
     @staticmethod
     def process_and_execute(statevector, tape, execute_and_derivatives=False):
-
         wires = statevector.num_wires
         device = LightningDevice(wires)
         if execute_and_derivatives:

tests/test_decomposition.py

@@ -90,7 +90,6 @@ def func(x, y):
         ):
             func(*params)
     if device_name == "lightning.kokkos":
-
         with pytest.raises(
             qml.DeviceError,
             match=r"Measurement shadow\(wires=\[0\]\) not accepted with finite shots on "