From 1fdbc95f058f38847f14716f8b55620eb769a3a3 Mon Sep 17 00:00:00 2001 From: Sida Wang <42928828+sida-wang@users.noreply.github.com> Date: Mon, 18 Dec 2023 22:22:17 +1100 Subject: [PATCH 1/2] fix: typo in comment --- src/Classes/SkillsTab.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Classes/SkillsTab.lua b/src/Classes/SkillsTab.lua index eaf843ac4b..a3af05d97a 100644 --- a/src/Classes/SkillsTab.lua +++ b/src/Classes/SkillsTab.lua @@ -312,7 +312,7 @@ function SkillsTabClass:LoadSkill(node, skillSetId) local gemData local possibleVariants = self.build.data.gemsByGameId[child.attrib.gemId] if possibleVariants then - -- If it is a known game, try to determine which variant is used + -- If it is a known gem, try to determine which variant is used if child.attrib.variantId then -- New save format from 3.23 that stores the specific variation (transfiguration) gemData = possibleVariants[child.attrib.variantId] From 69b200f031fa9055ac59536365f515d54004e8f6 Mon Sep 17 00:00:00 2001 From: Sida Wang <42928828+sida-wang@users.noreply.github.com> Date: Mon, 18 Dec 2023 22:23:01 +1100 Subject: [PATCH 2/2] fix: set variantId for transfig vaal gems --- src/Modules/Data.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Modules/Data.lua b/src/Modules/Data.lua index c3a1bf96f0..2395ae59f8 100644 --- a/src/Modules/Data.lua +++ b/src/Modules/Data.lua @@ -863,6 +863,7 @@ for gemId, gem in pairs(data.gems) do local newGem = copyTable(gem, true) newGem.name = "Vaal " .. data.skills[gem.secondaryGrantedEffectId..alt].name newGem.secondaryGrantedEffectId = gem.secondaryGrantedEffectId..alt + newGem.variantId = gem.variantId..alt --ConPrintf("Adding Gem: " .. newGem.name .. "\t" .. newGem.secondaryGrantedEffectId) data.gems[gemId..alt] = newGem setupGem(newGem, gemId..alt)