Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armour and ES Mastery not reflecting properly in Total Armour and ES Breakdowns in Calcs Tab #7386

Closed
2 tasks done
Puddlestomper opened this issue Mar 16, 2024 · 0 comments · Fixed by #7387
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@Puddlestomper
Copy link
Contributor

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

How is Path of Building expected to behave?

When viewing the breakdown of how a value was calculated (in this case Total Armour and Total Energy Shield in the calcs tab) it should display an accurate breakdown.

How does Path of Building behave?

When we allocate the Armour and ES mastery that says "100% increased Armour and Energy Shield from Equipped Body Armour if Equipped Helmet, Gloves, and Boots all have Armour and Energy Shield", then this 100% increased doesn't show in the breakdown. PoB does calculate it correctly, this is just a display issue.

How to reproduce the issue

  1. Make a new build.
  2. Allocate "Sanctum of Thought" which is close to the Templar start and the Divine Shield keystone.
  3. Allocate the mastery for "100% increased Armour and Energy Shield from Equipped Body Armour if Equipped Helmet, Gloves, and Boots all have Armour and Energy Shield".
  4. Equip armour/es bases with no mods for the Helmet, Body Armour, Gloves, and Boots slots.
  5. In the calcs tab, hover over the total Armour or ES to see the breakdown. Notice that the "Inc/red" multiplier for the body armour there does not include the 100% from the mastery. Also notice that this results in the values in the breakdown not adding up to the true Armour/ES value shown in the total, because PoB does calculate the mastery properly.

Character build code

https://pobb.in/ROa3CR-0WuiJ

Screenshots

image
This is the mastery I'm talking about.

image
The Total Armour breakdown where only the 38% increased armour from tree is factored in, causing the "Total" column not to add up to the true total. The difference between what the table adds up to and the true total is exactly the 553 from the body armour.

image
Same as above but for Energy Shield.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant