MessageID is reused when reusing SendOptions

[timbussmann]

When reusing SendOptions (or other option classes) for multiple sends, all outgoing messages have the same message id as the message id is generated when the options are instantiated. The following code causes all outgoing messages to use the same id:

var sendOptions = new SendOptions();
sendOptions.RouteToThisEndpoint();
await s.Send(new SomeCommand(), sendOptions);
await s.Send(new SomeCommand(), sendOptions);
await s.Send(new SomeCommand(), sendOptions);

Who's affected

Anyone who is using a the same instance of SendOptions, PublishOptions, ReplyOptions, SubscribeOptions or UnsubscribeOptions on multiple outgoing operations will be affected by this bug.

Symptoms

• It is possible that you will see more than one message with the same MessageId value in your auditing or error queues, or any tooling that consumes from those queues.
• When using the Outbox feature, you will see messages sent to one endpoint being discarded as they are perceived to be duplicate due to having the same MessageId as other messages.

Fixed in: 6.2.1

Also back-ported to

• 6.1.5 MessageID is reused when reusing SendOptions #4617
• 6.0.8 MessageID is reused when reusing SendOptions #4616