Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write log entry when publishing without subscribers when message driven pubsub is used #4119

Closed
ramonsmits opened this issue Sep 6, 2016 · 5 comments · Fixed by #5432
Closed
Assignees
Milestone

Comments

@ramonsmits
Copy link
Member

We seem to be officially support publishing on a send only endpoint (#2612).

For diagnostical purposes, I would propose to write a log entry with level WARN stating the following message

0 subscribers for event {0}, this can indicate a configuration issue. Are you running a send only instance and/or using volatile persistence?

Concerns:

  • It can actually be a valid configuration to not have subscribers. Instead of a WARN we could log this at a lower log level
  • To prevent log spamming the log entry could be written only once and tracked in a concurrent dictionary.
@andreasohlund
Copy link
Member

@andreasohlund
Copy link
Member

Note: this is only relevant for the message driven transports (msmq+asq+sql) since we have no way of knowing this with Rabbit+ASQ since the broker has that info

@Particular/rabbitmq-transport-maintainers does rabbit have some kind of native "if no binding was present let me know" feature?

@Particular/azure-service-bus-maintainers does ASB have some way of knowing that there was no one listening to the topic?
@az

@yvesgoeleven
Copy link
Contributor

yvesgoeleven commented Sep 6, 2016

@andreasohlund not really, but we can query the namespace for that info. But this is also a timing question, what if no one is listening yet (aka, subscriber is still booting up)

@WojcikMike
Copy link
Contributor

@andreasohlund there is mandatory flag that lets broker know if you should be informed if the message cannot be delivered to any queue (like publishing without subscribers). At the moment, mandatory flag is set for Sends (as the message should get to someone) and to not set for publish (as publishing with no subscriptions is considered valid scenario). So it seems that there could be an option to do something with it if needed.

@andreasohlund andreasohlund modified the milestone: Future Oct 6, 2016
@andreasohlund
Copy link
Member

@andreasohlund andreasohlund changed the title Write log entry when publishing without subscribers Write log entry when publishing without subscribers when message driven pubsub iis used Sep 21, 2018
@timbussmann timbussmann changed the title Write log entry when publishing without subscribers when message driven pubsub iis used Write log entry when publishing without subscribers when message driven pubsub is used Sep 26, 2019
@SeanFeldman SeanFeldman modified the milestones: Future, 7.2.0 Sep 27, 2019
@SeanFeldman SeanFeldman self-assigned this Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants