Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default video quality #901

Closed
ParticleCore opened this issue Jan 6, 2024 · 1 comment
Closed

Default video quality #901

ParticleCore opened this issue Jan 6, 2024 · 1 comment
Labels
Milestone

Comments

@ParticleCore
Copy link
Owner

Implement an option to memorize the last video quality selection.

Unlike the feature implemented in #18 this one does not offer a list of quality options to select from, instead when enabled it will memorize the user's last quality selection and enforce it during video playback whenever the current quality option returned by the player is "auto".

Whenever a certain quality is not available, the closest highest will be selected. For example, if the last selection was 1440p and the current video has a max quality of 720p then it will select the 720p option.

Although it limits the ability to set the preferred quality without opening a video, the feature was never designed to be used so often to justify having a complex configurable setting in the extension.

This can always be revisited in the future if it makes sense to implement a list of quality options in the settings. but for now this will be easier to implement and maintain.

@ParticleCore ParticleCore added this to the 2.0.0 milestone Jan 6, 2024
@ParticleCore
Copy link
Owner Author

Unfortunately the initial plan has an issue where there is currently no easy and certain way to tell if the user changed the quality, or the extension selected the closest highest quality, meaning the extension would have to either ignore this scenario (but then if the user were to intentionally change quality in this scenario the extension would also ignore it) or assume it is meant to save the new quality, which is a problem when it lowers the intended last quality as a result.

Seems like the original feature dropdown is still the most reliable option and so far seems to be working well.

@ParticleCore ParticleCore changed the title Memorize video quality Default video quality Jan 6, 2024
@ParticleCore ParticleCore moved this to Done in 2.0.0 Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant