-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade multi-lang implementation which may have broken in Storm 0.9.3 #82
Comments
And yet they still haven't updated the documentation for it. I find that the most frustrating part of working with Storm: the official documentation is very poorly formatted, and is frequently out of date. |
@dan-blanchard blame me, I recently voluntwered to update the Storm docs. Wanna help? :) |
I believe this diff shows the clearest indication of what actually changed. The only changes to the protocol I see are:
It also seems like it is recommended now that we use the |
Consider listing the actual changes to the API above my contribution to that effort. ;) Oh, and I should mentioned in my previous comment that heartbeats appear to only be sent to multilang bolts and not spouts. |
I've requested for pull to update documentation. |
patch from pyleus recently contributed: |
I should note that #87 made it so we're compatible with 0.9.3, but we're still not taking advantage of the ability to have custom metrics reported to Nimbus like was added in apache/storm#38. That should probably be a separate issue though. |
Storm 0.9.3 release notes indicate that "the multi-lang API has changed in a non-backward-compatible way". This has something to do with the way that ShellBolts implement heartbeat'ing / sync'ing. Should test, investigate, and upgrade as necessary the ipc module.
The text was updated successfully, but these errors were encountered: