Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds some more protection to SSD mobs with lwaps and snipers #28164

Merged
merged 3 commits into from
Feb 2, 2025

Conversation

1080pCat
Copy link
Contributor

@1080pCat 1080pCat commented Jan 28, 2025

What Does This PR Do

Made it so the LWAP doesn't mark SSD mobs.
Also made it so you don't hit SSD mobs with snipers/lwaps by shooting over them, as you could unintentionally hit them with a perpetrator round for example
Closes #28130

Why It's Good For The Game

SSD protection is good.

Images of changes

dreamseeker_npl6RiR9n8

Testing

Multi instance testing, shot over/at ssd mobs, and as shown above, ssd mobs aren't marked


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: The LWAP no longer marks SSD mobs
tweak: Sniper rifles/LWAPs no longer hit SSD mobs if you shoot over them.
/:cl:

Burzah
Burzah previously requested changes Jan 28, 2025
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR currently touches the config and is not needed. Please fix this.

@1080pCat
Copy link
Contributor Author

Your PR currently touches the config and is not needed. Please fix this.

Fixed, swore i unchecked that box..

@Burzah Burzah removed the request for review from AffectedArc07 January 28, 2025 13:19
@Burzah Burzah dismissed their stale review January 28, 2025 13:40

Changes made.

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting approval This PR is waiting for approval internally label Jan 28, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jan 29, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 31, 2025
@Burzah Burzah added the Tweak This PR tweaks something ingame label Feb 2, 2025
@Burzah Burzah added this pull request to the merge queue Feb 2, 2025
Merged via the queue into ParadiseSS13:master with commit 431656f Feb 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LWAP doesn't show SSD people as such
6 participants