Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes blind rushers hallucination runtimes #28084

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Toastical
Copy link
Contributor

@Toastical Toastical commented Jan 24, 2025

What Does This PR Do

Fixes #28054
The Blind Rusher timer failed to delete itself and would run indefinitely. This PR adds 2 QDELETED checks (from tgstation/tgstation#69879) in the timer fire proc. If the timer has been deleted inside it's callback, it wont reinsert itself.

Blind Rusher now has the TIMER_DELETE_ME flag instead of TIMER_STOPPABLE, as that seemed to always fail to delete.

Why It's Good For The Game

runtime spam not good

Testing

Invoked the hallucination on myself, didn't runtime, didn't run infinitely. Tried another TIMER_LOOP hallucination, deadchat control on a mob, the timers seem to run and delete. Aside of that, I have very surface level clue of what this actually does. Issues seemed related, so I gave it a shot.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 24, 2025
@Toastical Toastical marked this pull request as draft January 24, 2025 13:49
@Toastical Toastical closed this Jan 24, 2025
@Toastical Toastical reopened this Jan 28, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 29, 2025
@Toastical Toastical marked this pull request as ready for review January 31, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blind rushers halucination runtimes like crazy
2 participants