fixes blind rushers hallucination runtimes #28084
Open
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Fixes #28054
The Blind Rusher timer failed to delete itself and would run indefinitely. This PR adds 2 QDELETED checks (from tgstation/tgstation#69879) in the timer fire proc. If the timer has been deleted inside it's callback, it wont reinsert itself.
Blind Rusher now has the TIMER_DELETE_ME flag instead of TIMER_STOPPABLE, as that seemed to always fail to delete.
Why It's Good For The Game
runtime spam not good
Testing
Invoked the hallucination on myself, didn't runtime, didn't run infinitely. Tried another TIMER_LOOP hallucination, deadchat control on a mob, the timers seem to run and delete. Aside of that, I have very surface level clue of what this actually does. Issues seemed related, so I gave it a shot.
Declaration
Changelog
NPFC