Fire Alarms Never Clear Their Alert (Sometimes)

[Cress67]

Exploit Reports

• I confirm this issue is not an exploit. (Required)

BYOND Version

515.1641

Issue Description

Alerts are generated on the Station Alert Console and on any Synthetic's "Show Alerts" verb. They both bring up lists of station alerts, which are supposed to be current. Fire Alarm Alerts properly work if you just pull any given fire alarm, always being generated and then resolved when the fire alarm is unpulled. However, Fire Alarm Alerts that are generated due to actual atmospherics issues will never go away on the Alert listing. Whether due to the room being spaced or an actual fire, they simply remain eternally even when the alarm is unpulled.

What did you expect to happen?

I expected all Fire Alarm Alerts to eventually go away when the issue itself was solved.

What happened instead?

They stayed for the rest of the shift.

Why is this bad/What are the consequences?

It makes the Alerts listing incredibly cluttered, and can make it difficult to tell where actual issues are. The Atmospherics Alarm Alerts still work fine, at least, so you can just use that listing instead... but what's even the point of the Fire Alarm Alerts listing, then?

Steps to reproduce the issue.

Be a Synthetic and/or have access to a Station Alert Console (Engineering and the Bridge start with one). Pull a fire alarm, check the alerts, unpull the alarm, check the alerts. That works fine. Now RCD a hole in the floor or otherwise generate an atmospherics issues somewhere, to the point where the fire alarm activates. Check your alerts, confirm it's there. Fix the issue and unpull the alarm. Check your alerts, confirm it's still there even with the actual alarm untriggered.

When did the problem start happening?

Sometime around when MILLA 2 was merged, I'd guess. I don't remember it happening during MILLA itself.

Extra information

No response

Relevant log output/runtime error