From 57f6e4fa337559d8b3f754e3ddec2a950044beb4 Mon Sep 17 00:00:00 2001
From: Austin Miller <austinrmiller1991@gmail.com>
Date: Mon, 15 Aug 2022 12:33:33 -0700
Subject: [PATCH] fix: refining incoming actions (#69)

---
 Gemfile.lock                                           | 2 +-
 app/models/pager_tree/integrations/integration.rb      | 2 +-
 app/models/pager_tree/integrations/logic_monitor/v3.rb | 2 --
 app/models/pager_tree/integrations/new_relic/v3.rb     | 2 --
 app/models/pager_tree/integrations/webhook/v3.rb       | 2 --
 app/models/pager_tree/integrations/zendesk/v3.rb       | 2 --
 lib/generators/integration/templates/model.rb.tt       | 2 +-
 7 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/Gemfile.lock b/Gemfile.lock
index 9f83b79..4082cd2 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pager_tree-integrations (1.1.0)
+    pager_tree-integrations (1.1.1)
       rails (>= 7.0.1)
 
 GEM
diff --git a/app/models/pager_tree/integrations/integration.rb b/app/models/pager_tree/integrations/integration.rb
index 90364e5..5d52ce6 100644
--- a/app/models/pager_tree/integrations/integration.rb
+++ b/app/models/pager_tree/integrations/integration.rb
@@ -48,7 +48,7 @@ def adapter_incoming_can_defer?
       true
     end
 
-    # Returns :create, :acknowledge, :resolve, or :other
+    # Returns :create, :resolve, or :other
     def adapter_action
       :other
     end
diff --git a/app/models/pager_tree/integrations/logic_monitor/v3.rb b/app/models/pager_tree/integrations/logic_monitor/v3.rb
index 55826ba..0576af3 100644
--- a/app/models/pager_tree/integrations/logic_monitor/v3.rb
+++ b/app/models/pager_tree/integrations/logic_monitor/v3.rb
@@ -27,8 +27,6 @@ def adapter_action
       case alert_status
       when "active", "test"
         :create
-        # when "ack"
-        # :acknowledge
       when "clear"
         :resolve
       else
diff --git a/app/models/pager_tree/integrations/new_relic/v3.rb b/app/models/pager_tree/integrations/new_relic/v3.rb
index a0d35db..34d9f94 100644
--- a/app/models/pager_tree/integrations/new_relic/v3.rb
+++ b/app/models/pager_tree/integrations/new_relic/v3.rb
@@ -28,8 +28,6 @@ def adapter_action
 
       if event_type == "INCIDENT_OPEN" || (event_type == "INCIDENT" && current_state == "open")
         :create
-        # elsif event_type == "INCIDENT_ACKNOWLEDGED" || (event_type == "INCIDENT" && current_state == "acknowledged")
-        # :acknowledge
       elsif event_type == "INCIDENT_RESOLVED" || (event_type == "INCIDENT" && current_state == "closed")
         :resolve
       else
diff --git a/app/models/pager_tree/integrations/webhook/v3.rb b/app/models/pager_tree/integrations/webhook/v3.rb
index 56f629a..e3304bf 100644
--- a/app/models/pager_tree/integrations/webhook/v3.rb
+++ b/app/models/pager_tree/integrations/webhook/v3.rb
@@ -35,8 +35,6 @@ def adapter_action
       case adapter_incoming_request_params.dig("event_type").to_s.downcase.strip
       when "create"
         :create
-        # when "acknowledge"
-        # :acknowledge
       when "resolve"
         :resolve
       else
diff --git a/app/models/pager_tree/integrations/zendesk/v3.rb b/app/models/pager_tree/integrations/zendesk/v3.rb
index 7659e60..004bb60 100644
--- a/app/models/pager_tree/integrations/zendesk/v3.rb
+++ b/app/models/pager_tree/integrations/zendesk/v3.rb
@@ -26,8 +26,6 @@ def adapter_action
       case adapter_incoming_request_params.dig("event_type")
       when "create"
         :create
-      when "acknowledge"
-        :acknowledge
       when "resolve"
         :resolve
       else
diff --git a/lib/generators/integration/templates/model.rb.tt b/lib/generators/integration/templates/model.rb.tt
index 5427495..c907c51 100644
--- a/lib/generators/integration/templates/model.rb.tt
+++ b/lib/generators/integration/templates/model.rb.tt
@@ -35,7 +35,7 @@ module PagerTree::Integrations
       adapter_incoming_request_params.dig("id")
     end
 
-    # TODO: Returns :create, :acknowledge, :resolve, or :other
+    # TODO: Returns :create, :resolve, or :other
     def adapter_action
       :other
     end