Fix wind topic names for vtols #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaeyoung-Lim
force-pushed
the
pr-fix-windy-world
branch
from
18b49f7 to
bd307d6
Compare
TSC21
reviewed
Jul 23, 2020
|
@TSC21 That is actually why it was returning an error, since the world already has a wind topic published from gazebo by default, but the message definitions are different that is being used in the wind_plugin |
|
@TSC21 Hi Nuno! Can we get this in? |
TSC21
approved these changes
Aug 4, 2020
|
@TSC21 Thanks! |
|
@Jaeyoung-Lim Thanks for fixing this! The build process works now. But... The airspeed reading does not show the wind anymore. It's always roughly equal to the ground speed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The wind topic names were not properly updated in vtol models after #467 and the regression was caused by #490
Therefore resulting in a error shown in #551
Additional Context
Fixes #551