Make wind plugin a world plugin #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase? |
Jaeyoung-Lim
force-pushed
the
pr-wind-worldplugin
branch
2 times, most recently
from
698135f to
4e37b2c
Compare
|
@LorenzMeier Thanks! Done! |
Jaeyoung-Lim
force-pushed
the
pr-wind-worldplugin
branch
from
4e37b2c to
013d0a0
Compare
|
@Jaeyoung-Lim can you rebase? |
Jaeyoung-Lim
force-pushed
the
pr-wind-worldplugin
branch
from
013d0a0 to
afb649a
Compare
|
@TSC21 Thanks! Rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, wind was a gazebo model plugin since wind was simulated by applying "force" on a link. Since wind was a element inside the model, models could have different wind simulated even if they are in the same world.
However, this has changed since #462. Therefore, we can make the wind a property of the "world" and make different vehicles be affected to this no matter which vehicle is spawned in the world.
This PR enables the following