Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 [Patch]: Allow Set-GitHubDefaultContext to take context as pipeline #274

Merged
merged 9 commits into from
Jan 22, 2025

Conversation

MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Jan 20, 2025

Description

This pull request adds improvements to the Set-GitHubDefaultContext functionality, and additional test cases in GitHub.Tests.ps1 to test the new functionality.

Functionality Improvements:

  • Enhanced Set-GitHubDefaultContext to accept input from the pipeline by adding the ValueFromPipeline attribute to the Context parameter in src/functions/public/Auth/Context/Set-GitHubDefaultContext.ps1.
  • Added examples demonstrating how to set a default context using the pipeline in examples/Connecting.ps1.

Testing Enhancements:

  • Added new test cases to verify the Set-GitHubDefaultContext functionality, including swapping contexts using pipeline input in tests/GitHub.Tests.ps1.

Coverage Updates:

  • Updated the number of available and missing functions, which resulted in a slight decrease in overall coverage percentage in Coverage.md.
  • Added new endpoints related to network configurations in the coverage table in Coverage.md.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug self-assigned this Jan 20, 2025
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner January 20, 2025 21:27
Copy link
Contributor

Module [GitHub - v0.12.5-SetDefaultContextPipeline1] published to the PowerShell Gallery.

Copy link
Contributor

GitHub release for GitHub v0.12.5-SetDefaultContextPipeline1 has been created.

…e context resolution in `Set-GitHubDefaultContext`
Copy link
Contributor

Module [GitHub - v0.12.5-SetDefaultContextPipeline2] published to the PowerShell Gallery.

Copy link
Contributor

GitHub release for GitHub v0.12.5-SetDefaultContextPipeline2 has been created.

@MariusStorhaug MariusStorhaug merged commit 03b6e86 into main Jan 22, 2025
20 checks passed
@MariusStorhaug MariusStorhaug deleted the SetDefaultContextPipeline branch January 22, 2025 09:09
Copy link
Contributor

Module [GitHub - v0.12.5] published to the PowerShell Gallery.

Copy link
Contributor

GitHub release for GitHub v0.12.5 has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🩹 [Patch]: Allow piping a context to Set-GithubDefaultContext
1 participant