🩹 [Patch]: Change a contexts ApiBaseURI
data type from [uri]
to [string]
#268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to the GitHub API integration in the PowerShell scripts. The changes focus on ensuring the correct formatting of the API base URI and updating the data type for the
ApiBaseUri
property.This change is basically to have the
$context.ApiBaseURI
to be stored without the/
at the end, so that when runningInvoke-RestMethod
orInvoke-WebRequest
using the$context.ApiBaseURI
when creating the URI to use, you get a nice experience as seen in the example file.Changes to GitHub API integration:
examples/CallingAPIs.ps1
: Corrected the URI formatting by adding a slash before the endpoint in theInvoke-RestMethod
andInvoke-WebRequest
commands.src/classes/public/Context/GitHubContext.ps1
: Changed the data type of theApiBaseUri
property from[uri]
to[string]
to ensure compatibility with other parts of the code.src/functions/public/Auth/Connect-GitHubApp.ps1
: Updated theApiBaseUri
property data type from[uri]
to[string]
to match the changes inGitHubContext
.Type of change
Checklist