Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 [Patch]: Change a contexts ApiBaseURI data type from [uri] to [string] #268

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Jan 18, 2025

Description

This pull request includes several changes to the GitHub API integration in the PowerShell scripts. The changes focus on ensuring the correct formatting of the API base URI and updating the data type for the ApiBaseUri property.

This change is basically to have the $context.ApiBaseURI to be stored without the / at the end, so that when running Invoke-RestMethod or Invoke-WebRequest using the $context.ApiBaseURI when creating the URI to use, you get a nice experience as seen in the example file.

Changes to GitHub API integration:

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug self-assigned this Jan 18, 2025
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner January 18, 2025 15:46
@MariusStorhaug MariusStorhaug changed the title Change a contexts ApiBaseURI data type to string (was uri) 🩹 [Patch]: Change a contexts ApiBaseURI data type from [uri] to [string] Jan 18, 2025
@MariusStorhaug MariusStorhaug merged commit bf39035 into main Jan 18, 2025
20 checks passed
@MariusStorhaug MariusStorhaug deleted the apibaseuri branch January 18, 2025 16:48
Copy link
Contributor

Module [GitHub - v0.12.1] published to the PowerShell Gallery.

Copy link
Contributor

GitHub release for GitHub v0.12.1 has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant