Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 [Fix]: Set-GitHubOutput using SecureString in GitHub Actions #258

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Jan 13, 2025

Description

This pull request includes updates to the Set-GitHubOutput function and its corresponding tests to improve handling of secure strings.

Enhancements to Set-GitHubOutput function:

  • Removed the -Force parameter from the ConvertFrom-SecureString command as it does not support the switch. (src/functions/public/Commands/Set-GitHubOutput.ps1)

Improvements in test coverage:

  • Introduced new test cases to ensure the Set-GitHubOutput function handles secure strings and objects correctly without throwing errors. (tests/GitHub.Tests.ps1)

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug requested a review from a team as a code owner January 13, 2025 10:49
@MariusStorhaug MariusStorhaug self-assigned this Jan 13, 2025
@MariusStorhaug MariusStorhaug merged commit 7521adc into main Jan 13, 2025
20 checks passed
@MariusStorhaug MariusStorhaug deleted the secretOutput branch January 13, 2025 11:39
Copy link
Contributor

Module [GitHub - v0.11.44] published to the PowerShell Gallery.

Copy link
Contributor

GitHub release for GitHub v0.11.44 has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant