Enables hot reload #413
Merged
Enables hot reload #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- usage of async / await - improved readability of the code - console.error instead of console.log
Not all changes of the icons configuration do require a reload of the whole editor anymore.
ExE-Boss
reviewed
Mar 22, 2019
| icons/folder-root-open.svg | ||
|
|
||
| src/scripts/preview/*.html |
There was a problem hiding this comment.
Can you put a new‑line at the end of the file?
| "outFiles": [ | ||
| "${workspaceFolder}/out/test/**/*.js" | ||
| ], | ||
| "preLaunchTask": "npm: build" | ||
| "preLaunchTask": "npm: test-compile" | ||
| } | ||
| ] | ||
| } |
| yarn.lock | ||
| webpack.config.js |
| "include": [ | ||
| "src/**/*.ts", | ||
| "./node_modules/vscode/vscode.d.ts", | ||
| "./node_modules/vscode/lib/*", | ||
| ] | ||
| } |
| } | ||
| }; | ||
|
|
||
| module.exports = config; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables hot reload for some configurations of this extension. That means that a change of these configurations does not require a reload of the whole editor anymore. The changes will be visible immediately.
Hot reload will be possible for the following configurations:
Closes #249.