Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added I18N Simplified Chinese #133

Merged
merged 1 commit into from
Sep 16, 2017
Merged

Conversation

LeoEatle
Copy link

@LeoEatle LeoEatle commented Sep 16, 2017

Hi! Thanks for so many cool material icons.
Added support for locale: zh-CN which is simplified Chinese language to prevent the error Cannot find module './lang-zh-cn' when developing other VS Code extensions.

@LeoEatle LeoEatle changed the title added I18N Simplefied Chinese added I18N Simplified Chinese Sep 16, 2017
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, thank you! 👍

@PKief PKief merged commit bebc0be into material-extensions:master Sep 16, 2017
@PKief
Copy link
Member

PKief commented Sep 16, 2017

If you like you can also add a translation for the entries in the command palette. Therefor you just create a package.nls.zh-CN.json file in the root folder similar to the English file with the Chinese translation.

I added this for the French and German language already. For French it looks currently like this:

french_translation_image

But great job so far 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants