Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annoying restart notification #225

Closed
KillyMXI opened this issue Mar 18, 2018 · 8 comments
Closed

Annoying restart notification #225

KillyMXI opened this issue Mar 18, 2018 · 8 comments

Comments

@KillyMXI
Copy link


Is this notification supposed to be shown every time after the extension is updated and vscode already restarted?
Is there a real need for second restart? Is there anyone who really bother about this?
How can I disable this notification?

I have already set

    "material-icon-theme.showWelcomeMessage": false,
    "material-icon-theme.showUpdateMessage": false,

in my config.

@PKief
Copy link
Member

PKief commented Mar 18, 2018

I know, it's very annoying if the notification is shown after every update. The reason for this is that the extension is downloaded with the default settings. If you have some individual settings for the extension in your user settings (e.g. different color of the icons), the extension recognizes the changes in your user settings and processes them. To enable the changes, the extension asks you to reload the editor. Otherwise the changes on the icons will not be visible until the next restart.

Because this is a common issue in other icon themes, an issue was created at the VS Code repository with the request to update icons immediately without restarting the whole editor.

If this issue will not be solved by the VS Code team in the near future I'll set an option to disable the restart prompt.

@Tyriar
Copy link

Tyriar commented Mar 19, 2018

@PKief I was about to create the same issue, why is this being presented if I do not have individual settings?

screen shot 2018-03-19 at 6 25 35 am

Also do you expect high engagement on the changelog for an icons extension? Not sure presenting the changelog so prominently is a good UX.

PKief added a commit that referenced this issue Mar 19, 2018
@PKief
Copy link
Member

PKief commented Mar 19, 2018

@Tyriar Unfortunately the extension also watched the changes of the following settings:

"material-icon-theme.showUpdateMessage": false
"material-icon-theme.showWelcomeMessage": false

If they were set, no matter what value, then a restart was triggered.
I fixed it with 50e40e8#diff-c4136142413ab48def269bebf1c02f49R36.


I'm not sure about the changelog notification either. It has been part of my extension from the very beginning and nobody has complained about it since. But that doesn't mean that it is a good UX. Maybe I'll remove it in the future and probably nobody will miss it 😉

@Tyriar
Copy link

Tyriar commented Mar 20, 2018

@PKief thanks, yeah I had showWelcomeMessage set.

On the changelog, inside VS Code we try to use notifications very sparingly as they interrupt users so it needs to be important 😃

PKief added a commit that referenced this issue Apr 4, 2018
The notification which draws the attention to  the
changelog after each update of the extension is no longer displayed by default. But it can still be enabled with `"material-icon-theme.showUpdateMessage": true` in the user settings.

References #225
PKief added a commit that referenced this issue Apr 4, 2018
@PKief
Copy link
Member

PKief commented Apr 4, 2018

With the next update the configuration material-icon-theme.showUpdateMessage will be set to false by default. So there's no notification anymore that asks the user if he wants to read the changelog. If desired, the option can be set to true.

Additionally you can now completely disable the restart message with the following configuration:

"material-icon-theme.showReloadMessage": false

From my side I would not recommend to disable the restart message because your icons may look different after an update (because of the default configurations). But anyways, if the notifications interrupt your workflow then you can now disable all notifications from my extension.

@PKief PKief closed this as completed Apr 4, 2018
@KillyMXI
Copy link
Author

KillyMXI commented Apr 4, 2018

Thank you.
You could probably detect the default configuration though, where it is safe not to reload and no need for the message.

@PKief
Copy link
Member

PKief commented Apr 4, 2018

@KillyMXI Yes, this is already implemented. If no changes to the icons are required, then the extension will not prompt you to reload the window.

@Tyriar
Copy link

Tyriar commented Apr 4, 2018

Thanks @PKief 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants