Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent cursor type for the "following" and "fixed" position #144

Closed
s4my opened this issue Apr 1, 2024 · 2 comments · Fixed by #147
Closed

Inconsistent cursor type for the "following" and "fixed" position #144

s4my opened this issue Apr 1, 2024 · 2 comments · Fixed by #147

Comments

@s4my
Copy link

s4my commented Apr 1, 2024

Describe the bug
When the position is set to "following" or "fixed", some buttons have the "default" cursor type, others the "pointer" type.

Solution
I don't think we should use the "pointer" type; Obsidian doesn't use it anywhere on any of its buttons. To respect the Obsidian design system, I think we shouldn't either, plus the "pointer" cursor is usually only used on web applications.

I am willing to submit a PR to fix this issue if you're OK with my proposition.

@cumany
Copy link
Collaborator

cumany commented Apr 3, 2024

Thank you for pointing out this issue. The new version has been fixed. I'm not sure if the fix meets your expectations. Also, welcome to submit a pull request anytime.

cumany added a commit that referenced this issue Apr 3, 2024
@s4my
Copy link
Author

s4my commented Apr 4, 2024

Sure, but you introduced a bad styling for the hover style of the buttons. I think you're using a custom theme or something that is distorting your testing. This is how the hover style looks on default theme:

et

Sub-items have a different style too.
I fixed the issue with the PR #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants