db: Support setting browser preference

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 · Dec 26, 2024 · 609b3cf · 609b3cf
1 parent f4bfc31
commit 609b3cf
Show file tree

Hide file tree

Showing 18 changed files with 861 additions and 17 deletions.
diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
@@ -23,6 +23,10 @@
   "@settingsPageTitle": {
     "description": "Title for the settings page."
   },
+  "settingsUseExternal": "Use external browser",
+  "@settingsUseExternal": {
+    "description": "Whether to open links with external browser or not"
+  },
   "switchAccountButton": "Switch account",
   "@switchAccountButton": {
     "description": "Label for main-menu button leading to the choose-account page."

diff --git a/lib/generated/l10n/zulip_localizations.dart b/lib/generated/l10n/zulip_localizations.dart
@@ -139,6 +139,12 @@ abstract class ZulipLocalizations {
   /// **'Settings'**
   String get settingsPageTitle;
 
+  /// Whether to open links with external browser or not
+  ///
+  /// In en, this message translates to:
+  /// **'Use external browser'**
+  String get settingsUseExternal;
+
   /// Label for main-menu button leading to the choose-account page.
   ///
   /// In en, this message translates to:

diff --git a/lib/generated/l10n/zulip_localizations_ar.dart b/lib/generated/l10n/zulip_localizations_ar.dart
@@ -26,6 +26,9 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
   @override
   String get settingsPageTitle => 'Settings';
 
+  @override
+  String get settingsUseExternal => 'Use external browser';
+
   @override
   String get switchAccountButton => 'Switch account';
 

diff --git a/lib/generated/l10n/zulip_localizations_en.dart b/lib/generated/l10n/zulip_localizations_en.dart
@@ -26,6 +26,9 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
   @override
   String get settingsPageTitle => 'Settings';
 
+  @override
+  String get settingsUseExternal => 'Use external browser';
+
   @override
   String get switchAccountButton => 'Switch account';
 

diff --git a/lib/generated/l10n/zulip_localizations_fr.dart b/lib/generated/l10n/zulip_localizations_fr.dart
@@ -26,6 +26,9 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
   @override
   String get settingsPageTitle => 'Settings';
 
+  @override
+  String get settingsUseExternal => 'Use external browser';
+
   @override
   String get switchAccountButton => 'Switch account';
 

diff --git a/lib/generated/l10n/zulip_localizations_ja.dart b/lib/generated/l10n/zulip_localizations_ja.dart
@@ -26,6 +26,9 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
   @override
   String get settingsPageTitle => 'Settings';
 
+  @override
+  String get settingsUseExternal => 'Use external browser';
+
   @override
   String get switchAccountButton => 'Switch account';
 

diff --git a/lib/generated/l10n/zulip_localizations_pl.dart b/lib/generated/l10n/zulip_localizations_pl.dart
@@ -26,6 +26,9 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
   @override
   String get settingsPageTitle => 'Settings';
 
+  @override
+  String get settingsUseExternal => 'Use external browser';
+
   @override
   String get switchAccountButton => 'Switch account';
 

diff --git a/lib/generated/l10n/zulip_localizations_ru.dart b/lib/generated/l10n/zulip_localizations_ru.dart
@@ -26,6 +26,9 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
   @override
   String get settingsPageTitle => 'Settings';
 
+  @override
+  String get settingsUseExternal => 'Use external browser';
+
   @override
   String get switchAccountButton => 'Switch account';
 

diff --git a/lib/model/database.dart b/lib/model/database.dart
@@ -53,6 +53,9 @@ class Accounts extends Table {
 class GlobalSettings extends Table {
   Column<String> get themeSetting => textEnum<ThemeSetting>()
     .withDefault(const Variable('unset'))();
+
+  Column<String> get browserPreference => textEnum<BrowserPreference>()
+    .nullable()();
 }
 
 class UriConverter extends TypeConverter<Uri, String> {
@@ -73,7 +76,7 @@ class AppDatabase extends _$AppDatabase {
   //  * Write a migration in `onUpgrade` below.
   //  * Write tests.
   @override
-  int get schemaVersion => 3; // See note.
+  int get schemaVersion => 4; // See note.
 
   @override
   MigrationStrategy get migration {
@@ -104,6 +107,10 @@ class AppDatabase extends _$AppDatabase {
             from2To3: (m, schema) async {
               await m.createTable(schema.globalSettings);
             },
+            from3To4: (m, schema) async {
+              await m.addColumn(
+                schema.globalSettings, schema.globalSettings.browserPreference);
+            },
           ));
       });
   }

diff --git a/lib/model/database.g.dart b/lib/model/database.g.dart