Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint rules to makefile #246

Closed
DanRStevens opened this issue Feb 23, 2020 · 2 comments · Fixed by #251
Closed

Add lint rules to makefile #246

DanRStevens opened this issue Feb 23, 2020 · 2 comments · Fixed by #251

Comments

@DanRStevens
Copy link
Member

Would be handy to add lint rules to the makefile, so things like cppclean and cppcheck can be run easily. It would also provide some documentation that these tools can be used, and how to run them.

It would also be possible to setup a CI build that would run the lint tools on the code.

@cugone
Copy link
Contributor

cugone commented Feb 23, 2020

Some minimal research says that clang-tidy is built-in to VS 2019 16.4 or later.

@DanRStevens
Copy link
Member Author

I had kind of thought we'd already enabled Code Analysis for Visual Studio.


Interesting point from the link you gave:

Code Analysis defaults to the respective tool as dictated by your platform toolset and compiler: Microsoft Code Analysis if using MSVC (“Visual Studio 2019”) and clang-tidy if using LLVM/clang-cl.

It seems it changes the code analysis tools based on which compiler toolset you're using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants