Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock contract MockRebornMinter.sol causes Slither/Echidna failure #490

Open
franckc opened this issue Jan 8, 2021 · 1 comment
Open
Labels
bug Something isn't working contracts Works related to contracts P3 Users are not significantly affected, minor cosmetic issue

Comments

@franckc
Copy link

franckc commented Jan 8, 2021

When running Echidna, it first runs slither the following way:
slither . --ignore-compile --print echidna --json -
See this line of code in Echidna.

That generates an error:

{"success": false, "error": "Traceback (most recent call last):\n  File \"/Users/tom/.pyenv/versions/3.7.7/lib/python3.7/site-packages/slither/__main__.py\", line 712, in main_impl\n    ) = process_all(filename, args, detector_classes, printer_classes)\n  File \"/Users/tom/.pyenv/versions/3.7.7/lib/python3.7/site-packages/slither/__main__.py\", line 82, in process_all\n    ) = process_single(compilation, args, detector_classes, printer_classes)\n  File \"/Users/tom/.pyenv/versions/3.7.7/lib/python3.7/site-packages/slither/__main__.py\", line 67, in process_single\n    return _process(slither, detector_classes, printer_classes)\n  File \"/Users/tom/.pyenv/versions/3.7.7/lib/python3.7/site-packages/slither/__main__.py\", line 114, in _process\n    printer_results = slither.run_printers()\n  File \"/Users/tom/.pyenv/versions/3.7.7/lib/python3.7/site-packages/slither/slither.py\", line 192, in run_printers\n    return [p.output(self._crytic_compile.target).data for p in self._printers]\n  File \"/Users/tom/.pyenv/versions/3.7.7/lib/python3.7/site-packages/slither/slither.py\", line 192, in <listcomp>\n    return [p.output(self._crytic_compile.target).data for p in self._printers]\n  File \"/Users/tom/.pyenv/versions/3.7.7/lib/python3.7/site-packages/slither/printers/guidance/echidna.py\", line 376, in output\n    call_parameters = _call_a_parameter(self.slither)\n  File \"/Users/tom/.pyenv/versions/3.7.7/lib/python3.7/site-packages/slither/printers/guidance/echidna.py\", line 318, in _call_a_parameter\n    \"signature\": _get_name(ir.function),\n  File \"/Users/tom/.pyenv/versions/3.7.7/lib/python3.7/site-packages/slither/printers/guidance/echidna.py\", line 37, in _get_name\n    if f.is_fallback or f.is_receive:\nAttributeError: 'StateVariable' object has no attribute 'is_fallback'\n", "results": {}}

This is caused by the MockRebornMinter.sol

A workaround is to delete that contract when running Echidna, but it would be good to figure out a better solution.

@franckc franckc added bug Something isn't working contracts Works related to contracts P3 Users are not significantly affected, minor cosmetic issue labels Jan 8, 2021
@franckc
Copy link
Author

franckc commented Feb 25, 2022

@DanielVF I think you upgraded slither recently. Is this issue still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contracts Works related to contracts P3 Users are not significantly affected, minor cosmetic issue
Projects
None yet
Development

No branches or pull requests

1 participant